tx pool: Use class methods to hide raw map iterator impl details
ClosedPublic
Actions

Authored by deadalnix on Nov 30 2019, 22:30.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe635d1c6c5cd: tx pool: Use class methods to hide raw map iterator impl details
rABCe635d1c6c5cd: tx pool: Use class methods to hide raw map iterator impl details

Summary

This is a backport of Core PR13793

Depends on D4599

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 30 2019, 22:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2019, 22:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8357: Diff 14540.Nov 30 2019, 22:48

Fabien accepted this revision.Dec 2 2019, 08:06

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/txmempool.h
672 ↗	(On Diff #14540)	Update to comment to avoid confusion (hash -> txid)
677 ↗	(On Diff #14540)	Dito

This revision is now accepted and ready to land.Dec 2 2019, 08:06

Closed by commit rABCe635d1c6c5cd: tx pool: Use class methods to hide raw map iterator impl details (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyDec 2 2019, 14:40

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCe635d1c6c5cd: tx pool: Use class methods to hide raw map iterator impl details.

deadalnix added a commit: rSTAGINGe635d1c6c5cd: tx pool: Use class methods to hide raw map iterator impl details.Apr 7 2020, 21:57

Revision Contents
Changeset List

Path

Size

src/

txmempool.h

16 lines

txmempool.cpp

50 lines

Diff 14567

View Options

src/txmempool.h