Update mempool and compact block logic to use TxHash
ClosedPublic
Actions

Authored by deadalnix on Nov 30 2019, 21:49.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe37a511fd797: Update mempool and compact block logic to use TxHash
rABCe37a511fd797: Update mempool and compact block logic to use TxHash

Summary

This allowed to catch a few erroneous uses of GetId when GetHash should have been used, so this is already a plus.

Depends on D4599

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 30 2019, 21:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2019, 21:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8356: Diff 14539.Nov 30 2019, 22:06

Fabien accepted this revision.Dec 2 2019, 07:57

This revision is now accepted and ready to land.Dec 2 2019, 07:57

deadalnix retitled this revision from Update mempool and compact block logic to use TxHash . to Update mempool and compact block logic to use TxHash.Dec 2 2019, 14:39

Closed by commit rABCe37a511fd797: Update mempool and compact block logic to use TxHash (authored by deadalnix). · Explain WhyDec 2 2019, 14:47

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCe37a511fd797: Update mempool and compact block logic to use TxHash.

deadalnix added a commit: rSTAGINGe37a511fd797: Update mempool and compact block logic to use TxHash.Apr 7 2020, 21:57

Revision Contents
Changeset List

Path

Size

src/

blockencodings.h

4 lines

blockencodings.cpp

6 lines

net_processing.cpp

4 lines

primitives/

txid.h

1 line

test/

blockencodings_tests.cpp

10 lines

txmempool.h

2 lines

Diff 14568

View Options

src/blockencodings.h

View Options

src/blockencodings.cpp

View Options

src/net_processing.cpp

View Options

src/primitives/txid.h

View Options

src/test/blockencodings_tests.cpp

View Options

Update mempool and compact block logic to use TxHashClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14568

src/blockencodings.h

src/blockencodings.cpp

src/net_processing.cpp

src/primitives/txid.h

src/test/blockencodings_tests.cpp

src/txmempool.h

Update mempool and compact block logic to use TxHash
ClosedPublic
Actions

Revision Contents
Changeset List