Page MenuHomePhabricator

Update mempool and compact block logic to use TxHash
ClosedPublic

Authored by deadalnix on Nov 30 2019, 21:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe37a511fd797: Update mempool and compact block logic to use TxHash
Summary

This allowed to catch a few erroneous uses of GetId when GetHash should have been used, so this is already a plus.

Depends on D4599

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mempooltxhash
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8356
Build 14731: Bitcoin ABC Buildbot
Build 14730: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 30 2019, 21:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2019, 21:49
Fabien accepted this revision.Dec 2 2019, 07:57
This revision is now accepted and ready to land.Dec 2 2019, 07:57
deadalnix retitled this revision from Update mempool and compact block logic to use TxHash . to Update mempool and compact block logic to use TxHash.Dec 2 2019, 14:39
This revision was automatically updated to reflect the committed changes.