Page MenuHomePhabricator

Merge #13627: Free keystore.h from file scope level type aliases
ClosedPublic

Authored by nakihito on Dec 7 2019, 01:44.

Details

Summary

d0b9405f964670d6eaa8529f65fa7993b2a406c8 Refactors keystore.h type aliases. (251)

Pull request description:

This pull request frees `keystore.h` from type alias declarations that have been declared at file scope level.

`keystore.h` has various type aliases that have been declared ~3 - 6 years ago at file scope level, which can either be encapsulated or removed.

Where type alias declarations are encapsulated at the appropriate scope and access level, C++11's `using` notation is used in favor of the `typedef` notation.

Tree-SHA512: 1395cdc63e0c7ff5a1b1721675ad4416f71f507e999bd4ba019f03457cbfc08877848f10a8db7f5ccd2cd5ca3f5a291c986616f7703172fb6d79fba7447ffba8

Backport of Core PR13627
https://github.com/bitcoin/bitcoin/pull/13627/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13627
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8450
Build 14911: Default Diff Build & Tests
Build 14910: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Dec 7 2019, 01:44
nakihito requested review of this revision.Dec 9 2019, 18:22
This revision is now accepted and ready to land.Dec 9 2019, 18:52