Page MenuHomePhabricator
Differential D4675

Extract CWallet::MarkInputsDirty
ClosedPublic
Actions

Authored by nakihito on Dec 10 2019, 01:58.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe5119ad26b63: Extract CWallet::MarkInputsDirty
rABCe5119ad26b63: Extract CWallet::MarkInputsDirty
Summary

To avoid repeated implementations.

Partial backport of Core PR13651
https://github.com/bitcoin/bitcoin/pull/13651/commits/b7f565094296b727d1309418d3a284d942f15f11

Depends on D4674

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13651-1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8466
Build 14943: Default Diff Build & Tests
Build 14942: arc lint + arc unit

Event Timeline

nakihito created this revision.Dec 10 2019, 01:58
Owners added a reviewer: Restricted Owners Package.Dec 10 2019, 01:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2019, 01:58
teamcity added a comment.Dec 10 2019, 01:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito planned changes to this revision.Dec 10 2019, 01:59
nakihito updated this revision to Diff 14713.Dec 10 2019, 02:03

Reformatted comment.

teamcity added a comment.Dec 10 2019, 02:03

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D4676: Privatize CWallet::AddToWalletIfInvolvingMe.Dec 10 2019, 02:05
teamcity added a comment.Dec 10 2019, 02:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8465: Diff 14712.Dec 10 2019, 02:10
teamcity added a comment.Dec 10 2019, 02:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8466: Diff 14713.Dec 10 2019, 02:18
jasonbcox accepted this revision.Dec 11 2019, 02:13
This revision is now accepted and ready to land.Dec 11 2019, 02:13
Closed by commit rABCe5119ad26b63: Extract CWallet::MarkInputsDirty (authored by Ben Woosley <ben.woosley@gmail.com>, committed by nakihito). · Explain WhyDec 11 2019, 19:20
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCe5119ad26b63: Extract CWallet::MarkInputsDirty.
nakihito mentioned this in D4700: Remove Unused CTransaction tx in wallet.cpp.Dec 11 2019, 21:28
nakihito mentioned this in rABC93156fddade6: Remove Unused CTransaction tx in wallet.cpp.Dec 11 2019, 21:50
nakihito added a commit: rSTAGINGe5119ad26b63: Extract CWallet::MarkInputsDirty.Apr 7 2020, 22:02
nakihito mentioned this in rSTAGING93156fddade6: Remove Unused CTransaction tx in wallet.cpp.

Revision Contents
Changeset List

PathSize
src/
wallet/
6 lines
32 lines

Diff 14713

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...