Remove unused functions in seeder/db.h
ClosedPublic
Actions

Authored by nakihito on Dec 11 2019, 01:03.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING1d1a86083dda: Remove unused functions in seeder/db.h
rABC1d1a86083dda: Remove unused functions in seeder/db.h

Summary

These functions are not used at all.

Test Plan

make check

The following 5 commands should output nothing:

grep -rnI Skipped\(
grep -rnI Skipped_\(
grep -rnI Bad\(
grep -rnI Get\(
grep -rnI GetMany_\(
grep -rnI Good\(

The last command above should output the following:

db.h:115:        ret.fGood = IsGood();
db.h:120:    bool IsGood() const {
db.h:161:        if (IsGood()) {
db.h:183:        if (IsGood()) {
db.h:406:                    if (info.IsGood()) {
db.cpp:100:    if (info.IsGood() && goodId.count(id) == 0) {
db.cpp:131:        if (/*!info.IsGood() && */ goodId.count(id) == 1) {

Diff Detail

Repository

rABC Bitcoin ABC

Branch

CleanUpDB

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8494
Build 14996: Default Diff Build & Tests
Build 14995: arc lint + arc unit

Event Timeline

nakihito created this revision.Dec 11 2019, 01:03

Owners added a reviewer: Restricted Owners Package.Dec 11 2019, 01:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2019, 01:03

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Dec 11 2019, 01:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8494: Diff 14758.Dec 11 2019, 01:16

If you are going to clean this up, actually clean it up. There are other dead functions, in fact there is a function that is declared and NEVER defined anywhere.

This revision now requires changes to proceed.Dec 11 2019, 02:18

nakihito edited the test plan for this revision. (Show Details)Dec 11 2019, 21:35