[UBSAN] Update exceptions
ClosedPublic
Actions

Authored by Fabien on Dec 12 2019, 14:07.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING154f9a0782aa: [UBSAN] Update exceptions
rABC154f9a0782aa: [UBSAN] Update exceptions

Summary

This diff adds a new sanitizer exception entry to avoid a vptr issue
caused by the boost test case timeout in the avalanche unit test
poll_inflight_timeout. For some unknown reason this issue only
triggers when building with cmake, and only with clang 7 (8 and 9 are
OK).

Test Plan

mkdir -p buildcmake && cd buildcmake
cmake -GNinja .. -DCMAKE_C_COMPILER=clang-7 -DCMAKE_CXX_COMPILER=clang++-7 -DCMAKE_BUILD_TYPE=Debug -DENABLE_SANITIZERS=undefined
ninja
export UBSAN_OPTIONS="suppressions=../sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1"
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ubsan_update_exceptions

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8521
Build 15041: Default Diff Build & Tests
Build 15040: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 12 2019, 14:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 12 2019, 14:07

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8521: Diff 14797.Dec 12 2019, 14:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien planned changes to this revision.Dec 12 2019, 15:49

Fabien edited the summary of this revision. (Show Details)Dec 12 2019, 15:55

Fabien edited the test plan for this revision. (Show Details)

Don't remove the functional test.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8524: Diff 14801.Dec 12 2019, 16:09

Fabien added a child revision: D4711: [CI] Migrate the CI to use cmake and ninja.Dec 12 2019, 16:41

The docs make no mention of comments working in the suppressions file, but it would be nice if we could comment this line that it only affects builds using clang-7

This revision is now accepted and ready to land.Dec 12 2019, 17:15

Add a comment.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8541: Diff 14826.Dec 13 2019, 07:39

Closed by commit rABC154f9a0782aa: [UBSAN] Update exceptions (authored by Fabien). · Explain WhyDec 13 2019, 07:49

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC154f9a0782aa: [UBSAN] Update exceptions.

Fabien removed a child revision: D4711: [CI] Migrate the CI to use cmake and ninja.Dec 13 2019, 07:52

Fabien added a commit: rSTAGING154f9a0782aa: [UBSAN] Update exceptions.Apr 7 2020, 22:04