Paths

Table of Contentst

Update seeder to use int64_t instead of time_t for Darwin
ClosedPublic
Actions

Authored by schancel on Oct 3 2017, 15:53.

Details

Reviewers

kyuupichan
deadalnix
freetrader

Group Reviewers

Restricted Project

Commits

rSTAGING5223ee075e1b: Update seeder to use int64_t instead of time_t for Darwin
rABC5223ee075e1b: Update seeder to use int64_t instead of time_t for Darwin

Summary

On MacOS X, time_t is a typedef for long. In order to
compile bitcoin-seeder on MacOS X we need to not
use time_t, and instead use int64_t.

Test Plan

make VERBOSE=1 check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

shammah/fix-seeder-macosx

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 938
Build 938: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 3 2017, 15:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2017, 15:53

I suspect this is totally wrong due to 64bit vs 32bit. This probably should not be merged. I'll look at a more comprehensive fix.

deadalnix requested changes to this revision.Oct 3 2017, 15:56

deadalnix added inline comments.

src/serialize.h
191 ↗	(On Diff #1479)	The size of a long is system dependent, you can't do that.

This revision now requires changes to proceed.Oct 3 2017, 15:56

Change time_t to int64_t to fix compiling on MacOS X

Harbormaster completed remote builds in B937: Diff 1481.Oct 4 2017, 01:05

schancel edited the summary of this revision. (Show Details)Oct 4 2017, 04:46

kyuupichan added inline comments.Oct 4 2017, 05:39

src/seeder/db.h
287 ↗	(On Diff #1481)	Why unsigned here and signed everywhere else?

Fix banned list to use int64_t for time.

schancel added inline comments.Oct 4 2017, 06:23

src/seeder/db.h
287 ↗	(On Diff #1481)	Because I'm blind.
src/serialize.h
191 ↗	(On Diff #1479)	👍 We're in agreement, I had already commented about that.

Builds and makes check for me.

I still have warnings on Mac, I'll try and squash those myself.

schancel retitled this revision from Add Serialize and Unserialize specializations for long to Update seeder to use int64_t instead of time_t for Darwin.Oct 4 2017, 07:43

deadalnix accepted this revision.Oct 4 2017, 08:18

This revision is now accepted and ready to land.Oct 4 2017, 08:18

Closed by commit rABC5223ee075e1b: Update seeder to use int64_t instead of time_t for Darwin (authored by schancel, committed by deadalnix). · Explain WhyOct 4 2017, 10:53

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

seeder/

db.h

6 lines

db.cpp

4 lines

Diff 1482

View Options

src/seeder/db.h