Page MenuHomePhabricator
Differential D4698

[CMAKE] Allow to run boost unit tests in parallel
ClosedPublic
Actions

Authored by Fabien on Dec 11 2019, 16:52.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING023d88136c94: [CMAKE] Allow to run boost unit tests in parallel
rABC023d88136c94: [CMAKE] Allow to run boost unit tests in parallel
Summary

This is inspired from the autotools equivalent, ported in D3535.
The idea is to run each test in it's own process by passing it to the
boost test filter. Then it relies on ninja to run them in parallel.

This implies the removal of ctest.

Test Plan
cmake -GNinja ..
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_parallel_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8615
Build 15217: Default Diff Build & Tests
Build 15216: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 11 2019, 16:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2019, 16:52
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 11 2019, 16:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 11 2019, 17:02

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8501: Diff 14767.Dec 11 2019, 17:02
deadalnix requested changes to this revision.Dec 13 2019, 02:52

That is not a good solution if you need to specify the parallelism level for the test. ninja already does job scheduling.

This revision now requires changes to proceed.Dec 13 2019, 02:52
Fabien planned changes to this revision.Dec 13 2019, 15:28
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)Dec 13 2019, 15:30
Fabien updated this revision to Diff 14836.Dec 13 2019, 15:39

Remove ctest to let ninja do the job scheduling.

teamcity added a comment.Dec 13 2019, 15:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 13 2019, 15:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8547: Diff 14836.Dec 13 2019, 15:57
deadalnix added a comment.Dec 16 2019, 15:26

Does this keep running the test suite once a test fails?

Fabien added a comment.Dec 16 2019, 15:41

No, it stops on first failure (minus the already started jobs). It has the same behavior than autotools.

deadalnix accepted this revision.Dec 17 2019, 23:24
This revision is now accepted and ready to land.Dec 17 2019, 23:24
Fabien updated this revision to Diff 14952.Dec 18 2019, 07:28

Rebase

teamcity added a comment.Dec 18 2019, 07:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 18 2019, 07:48
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Harbormaster failed remote builds in B8615: Diff 14952!Dec 18 2019, 07:48
Fabien updated this revision to Diff 14958.Dec 18 2019, 08:46

Reference the template from the module file rather than project to
avoid failure when building secp256k1 standalone.

teamcity added a comment.Dec 18 2019, 08:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 18 2019, 09:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8618: Diff 14958.Dec 18 2019, 09:11
Fabien updated this revision to Diff 14959.Dec 18 2019, 09:17

Re-add mistakenly deleted newline.

teamcity added a comment.Dec 18 2019, 09:17

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 18 2019, 09:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8619: Diff 14959.Dec 18 2019, 09:27
Closed by commit rABC023d88136c94: [CMAKE] Allow to run boost unit tests in parallel (authored by Fabien). · Explain WhyDec 18 2019, 09:30
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC023d88136c94: [CMAKE] Allow to run boost unit tests in parallel.
Fabien mentioned this in D4770: [CMAKE] Unbreak the activated tests.Dec 19 2019, 16:13
Fabien mentioned this in rABC3c51eb3130c5: [CMAKE] Unbreak the activated tests.Dec 19 2019, 21:24
jasonbcox mentioned this in D5008: [CMAKE] Run wallet tests as part of the check-bitcoin target.Jan 17 2020, 22:32
Fabien added a commit: rSTAGING023d88136c94: [CMAKE] Allow to run boost unit tests in parallel.Apr 7 2020, 22:08
Fabien mentioned this in rSTAGING3c51eb3130c5: [CMAKE] Unbreak the activated tests.

Revision Contents
Changeset List

PathSize
cmake/
modules/
50 lines
templates/
3 lines
src/
test/
198 lines

Diff 14952

View Options

cmake/modules/TestSuite.cmake

Loading...
View Options

cmake/templates/TestRunner.cmake.in

Loading...
View Options

src/test/CMakeLists.txt

Loading...