Page MenuHomePhabricator
Differential D4784

[CMAKE] Allow to run the extended functional tests
ClosedPublic
Actions

Authored by Fabien on Dec 20 2019, 14:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING00843b24874c: [CMAKE] Allow to run the extended functional tests
rABC00843b24874c: [CMAKE] Allow to run the extended functional tests
Summary

This adds a couple targets to run the extended functional tests, with or
without the next upgrade activated.

Depends on D4783.

Test Plan
ninja check-functional-extended
ninja check-functional-extended-upgrade-activated

Check all the tests are run.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_function_tests_extended
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8661
Build 15308: Default Diff Build & Tests
Build 15307: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 20 2019, 14:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 20 2019, 14:53
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 20 2019, 14:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 20 2019, 15:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8661: Diff 15026.Dec 20 2019, 15:03
deadalnix requested changes to this revision.Dec 20 2019, 15:33

This is not the right approach. Why would someone would have to reconfigure the build to run extended tests?

What you need is a check-function-extended and check-extended targets.

This revision now requires changes to proceed.Dec 20 2019, 15:33
Fabien planned changes to this revision.Dec 23 2019, 20:29
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)
Fabien updated this revision to Diff 15081.Dec 23 2019, 20:38

Don't require build time configuration.

teamcity added a comment.Dec 23 2019, 20:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4801: [CMAKE] Make check-upgrade-activated run the extended functional tests.Dec 23 2019, 20:43
teamcity added a comment.Dec 23 2019, 20:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8687: Diff 15081.Dec 23 2019, 20:48
deadalnix accepted this revision.Jan 2 2020, 06:35
This revision is now accepted and ready to land.Jan 2 2020, 06:35
Closed by commit rABC00843b24874c: [CMAKE] Allow to run the extended functional tests (authored by Fabien). · Explain WhyJan 2 2020, 09:13
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC00843b24874c: [CMAKE] Allow to run the extended functional tests.
Fabien removed a child revision: D4801: [CMAKE] Make check-upgrade-activated run the extended functional tests.Jan 10 2020, 13:20
Fabien added a commit: rSTAGING00843b24874c: [CMAKE] Allow to run the extended functional tests.Apr 7 2020, 22:14

Revision Contents
Changeset List

PathSize
test/
6 lines

Diff 15026

View Options

test/CMakeLists.txt

Loading...