Page MenuHomePhabricator
Differential D4835

VerifyScript: accumulate ScriptExecutionMetrics and return them
ClosedPublic
Actions

Authored by markblundeberg on Jan 5 2020, 04:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T704: sigChecks implementation
Commits
rSTAGING3340ff368183: VerifyScript: accumulate ScriptExecutionMetrics and return them
rABC3340ff368183: VerifyScript: accumulate ScriptExecutionMetrics and return them
Summary

This exposes the input-total metrics for VerifyScript callers, so it
can be used in CheckInputs (-> mempool tracking, scriptcache, connectblock
checking).

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sigchecksD
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8743
Build 15470: Default Diff Build & Tests
Build 15469: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 5 2020, 04:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2020, 04:11
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 5 2020, 04:11

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 5 2020, 04:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8742: Diff 15161.Jan 5 2020, 04:18
markblundeberg planned changes to this revision.Jan 5 2020, 04:49
markblundeberg mentioned this in D4617: add a flag that restricts sigChecks per-input.
markblundeberg added a task: T704: sigChecks implementation.Jan 5 2020, 05:01
markblundeberg updated this revision to Diff 15162.Jan 5 2020, 05:16
markblundeberg retitled this revision from add ScriptExecutionMetrics return-by-ref to VerifyScript to VerifyScript: accumulate ScriptExecutionMetrics and return them.
markblundeberg edited the summary of this revision. (Show Details)

absorb things from D4617 and flip dependency

teamcity added a comment.Jan 5 2020, 05:16

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg removed a parent revision: D4617: add a flag that restricts sigChecks per-input.Jan 5 2020, 05:17
markblundeberg added a child revision: D4617: add a flag that restricts sigChecks per-input.Jan 5 2020, 05:18
teamcity added a comment.Jan 5 2020, 05:22

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8743: Diff 15162.Jan 5 2020, 05:22
deadalnix requested changes to this revision.Jan 5 2020, 09:38
deadalnix added inline comments.
src/script/interpreter.cpp
1709

This is a pretty bad API. You can instead create a local variable, use that, and merge it at the end.

This revision now requires changes to proceed.Jan 5 2020, 09:38
markblundeberg updated this revision to Diff 15214.Jan 8 2020, 06:42

copy to outparam rather than reset-modifying outparam

teamcity added a comment.Jan 8 2020, 06:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 8 2020, 06:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8776: Diff 15214.Jan 8 2020, 06:49
deadalnix accepted this revision.Jan 8 2020, 13:23
This revision is now accepted and ready to land.Jan 8 2020, 13:23
Closed by commit rABC3340ff368183: VerifyScript: accumulate ScriptExecutionMetrics and return them (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyJan 12 2020, 05:26
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC3340ff368183: VerifyScript: accumulate ScriptExecutionMetrics and return them.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING3340ff368183: VerifyScript: accumulate ScriptExecutionMetrics and return them.Apr 7 2020, 22:23

Revision Contents
Changeset List

PathSize
src/
script/
10 lines
12 lines
test/
37 lines

Diff 15162

View Options

src/script/interpreter.h

Loading...
View Options

src/script/interpreter.cpp

Loading...
View Options

src/test/sigcheckcount_tests.cpp

Loading...