Page MenuHomePhabricator

VerifyScript: accumulate ScriptExecutionMetrics and return them

Authored by markblundeberg on Jan 5 2020, 04:11.



This exposes the input-total metrics for VerifyScript callers, so it
can be used in CheckInputs (-> mempool tracking, scriptcache, connectblock

Test Plan

ninja check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jan 5 2020, 04:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2020, 04:11
markblundeberg retitled this revision from add ScriptExecutionMetrics return-by-ref to VerifyScript to VerifyScript: accumulate ScriptExecutionMetrics and return them.
markblundeberg edited the summary of this revision. (Show Details)

absorb things from D4617 and flip dependency

deadalnix requested changes to this revision.Jan 5 2020, 09:38
deadalnix added inline comments.
1709 ↗(On Diff #15162)

This is a pretty bad API. You can instead create a local variable, use that, and merge it at the end.

This revision now requires changes to proceed.Jan 5 2020, 09:38

copy to outparam rather than reset-modifying outparam

deadalnix accepted this revision.Jan 8 2020, 13:23
This revision is now accepted and ready to land.Jan 8 2020, 13:23