Page MenuHomePhabricator

VerifyScript: accumulate ScriptExecutionMetrics and return them
ClosedPublic

Authored by markblundeberg on Sun, Jan 5, 04:11.

Details

Summary

This exposes the input-total metrics for VerifyScript callers, so it
can be used in CheckInputs (-> mempool tracking, scriptcache, connectblock
checking).

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Sun, Jan 5, 04:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Jan 5, 04:11
markblundeberg retitled this revision from add ScriptExecutionMetrics return-by-ref to VerifyScript to VerifyScript: accumulate ScriptExecutionMetrics and return them.
markblundeberg edited the summary of this revision. (Show Details)

absorb things from D4617 and flip dependency

deadalnix requested changes to this revision.Sun, Jan 5, 09:38
deadalnix added inline comments.
src/script/interpreter.cpp
1709 ↗(On Diff #15162)

This is a pretty bad API. You can instead create a local variable, use that, and merge it at the end.

This revision now requires changes to proceed.Sun, Jan 5, 09:38

copy to outparam rather than reset-modifying outparam

deadalnix accepted this revision.Wed, Jan 8, 13:23
This revision is now accepted and ready to land.Wed, Jan 8, 13:23