Page MenuHomePhabricator
Differential D4855

[SECP256K1] Move the autotools Travis build to it's own script
ClosedPublic
Actions

Authored by Fabien on Jan 8 2020, 14:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf186a4bd2d31: [SECP256K1] Move the autotools Travis build to it's own script
rABCf186a4bd2d31: [SECP256K1] Move the autotools Travis build to it's own script
Summary

This will make it easier to follow when introducing the cmake build into
Travis.

There is no change in behavior.

Test Plan

Run the script, run the travis build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1_travis_autotools_script
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8811
Build 15597: Default Diff Build & Tests
Build 15596: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 8 2020, 14:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2020, 14:35
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 8 2020, 14:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 8 2020, 14:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8783: Diff 15223.Jan 8 2020, 14:40
Fabien added a child revision: D4856: [SECP256k1] Add the CMake/Ninja build to Travis.Jan 8 2020, 15:07
deadalnix requested changes to this revision.Jan 8 2020, 17:32
deadalnix added inline comments.
src/secp256k1/.travis.yml
60 ↗(On Diff #15223)

contrib doesn't seems to be the right place for this project. There is code in there.

This revision now requires changes to proceed.Jan 8 2020, 17:32
Fabien edited the summary of this revision. (Show Details)Jan 9 2020, 07:12
Fabien removed a parent revision: D4854: [SECP256K1] Add a case with Schnorr disabled to the Travis matrix.
Fabien updated this revision to Diff 15255.Jan 9 2020, 08:04

Address feedbacks (also from D4856):

  • Move the scripts out of contrib/
  • Set the locale (the linter didn't throw because secp256k1 is excluded, I will update this in another diff)
  • Use set -x instead of set -v for consistency
  • Don't export script scoped variables.
teamcity added a comment.Jan 9 2020, 08:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 9 2020, 08:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8811: Diff 15255.Jan 9 2020, 08:21
deadalnix accepted this revision.Jan 9 2020, 11:31
This revision is now accepted and ready to land.Jan 9 2020, 11:31
Closed by commit rABCf186a4bd2d31: [SECP256K1] Move the autotools Travis build to it's own script (authored by Fabien). · Explain WhyJan 9 2020, 14:10
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf186a4bd2d31: [SECP256K1] Move the autotools Travis build to it's own script.
Fabien added a commit: rSTAGINGf186a4bd2d31: [SECP256K1] Move the autotools Travis build to it's own script.Apr 7 2020, 22:20

Revision Contents
Changeset List

PathSize
src/
secp256k1/
5 lines
travis/
36 lines

Diff 15255

View Options

src/secp256k1/.travis.yml

Loading...
View Options

src/secp256k1/travis/build_autotools.sh

Loading...