Fix compile errors in Amount caused by ambiguous instantation
ClosedPublic
Actions

Authored by tomtomtom7 on Oct 10 2017, 14:13.

Details

Reviewers

schancel
deadalnix

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGf1a0dab0217c: Fix compile errors in Amount caused by ambiguous instantation
rABCf1a0dab0217c: Fix compile errors in Amount caused by ambiguous instantation

Summary

Amount(long long) was ambiguous causing compile errors. Instantiation is now generalized to all integers

Test Plan

None; minor refactoring only

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomtomtom7 created this revision.Oct 10 2017, 14:13

Owners added a reviewer: Restricted Owners Package.Oct 10 2017, 14:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2017, 14:13

schancel added a reviewer: deadalnix.Oct 10 2017, 14:34

I've added Amaury as a reviewer. He did not like using a template for some reason in previous revisions.

src/amount.h
22 ↗	(On Diff #1533)	Originally I had used: template <typename T, typename std::enable_if<(std::is_integral<T>::value). T>::type = 0> rather than a static_assert You should include type_traits also I think?

deadalnix added inline comments.Oct 10 2017, 14:38

src/amount.h
22 ↗	(On Diff #1533)	static assert sounds much clearer. is there a way to get an error message out of it ?

Add message to static assert

Harbormaster completed remote builds in B977: Diff 1536.Oct 10 2017, 14:54

Added include type_traits

schancel accepted this revision.Oct 10 2017, 15:16

This revision is now accepted and ready to land.Oct 10 2017, 15:16

Closed by commit rABCf1a0dab0217c: Fix compile errors in Amount caused by ambiguous instantation (authored by tomtomtom7, committed by tomtomtom7). · Explain WhyOct 10 2017, 15:30

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

amount.h

11 lines

Diff 1539

View Options

Fix compile errors in Amount caused by ambiguous instantationClosedPublicActions