Page MenuHomePhabricator
Differential D598

MalFix: Drop auto-requesting parents of orphans from the same peer
AbandonedPublic
Actions

Authored by jasonbcox on Oct 13 2017, 07:43.

Details

Reviewers
deadalnix
tomtomtom7
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

The code used to try to fetch the parent on receiving an orphan.
This is no longer possible as the TXID of the parent is unknown. We must
now rely on ordinary propagation of the parent.

Test Plan

Only logic removed that wasn't covered by testcases

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/net_processing.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 984
Build 984: arc lint + arc unit

Event Timeline

tomtomtom7 created this revision.Oct 13 2017, 07:43
Owners added a reviewer: Restricted Owners Package.Oct 13 2017, 07:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 13 2017, 07:43
deadalnix added a subscriber: deadalnix.Oct 13 2017, 15:35

That doesn't seems like the right path, and this is why I insisted initially on differentiating on txid/txhash. We use txidid pretty much everywhere, except in the merkle tree where we use txhash.

deadalnix added a comment.Oct 14 2017, 01:36

Segwit uses a flag in inv, this seems like the right approach to me.

deadalnix requested changes to this revision.Dec 5 2017, 15:00

CInv support flags. This should be leveraged instead of dropping the feature altogether.

This revision now requires changes to proceed.Dec 5 2017, 15:00
jasonbcox commandeered this revision.Apr 23 2019, 16:58
jasonbcox abandoned this revision.
jasonbcox added a reviewer: tomtomtom7.

Revision Contents
Changeset List

PathSize
src/
56 lines

Diff 1545

View Options

src/net_processing.cpp

Loading...