Page MenuHomePhabricator

[CMAKE] Fix daemon() detection on OSX
ClosedPublic

Authored by Fabien on Jan 17 2020, 20:34.

Details

Summary

On BSDs and macOS, the daemon() function is located in stdlib.h.

Test Plan

On OSX:

cmake -GNinja ..

Check daemon is found.

ninja
./src/bitcoind -daemon

Check the argument is supported and works as expected.

Run the OSX Gitian build and test the -daemon option is supported on
the produced bitcoind binary.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_daemon_osx
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9033
Build 16028: Default Diff Build & Tests
Build 16027: arc lint + arc unit

Event Timeline

I tested the binary from the Gitian build and it doesn't have the issue.

This revision is now accepted and ready to land.Jan 17 2020, 20:46
This revision was automatically updated to reflect the committed changes.