Page MenuHomePhabricator
Differential D5051

ui: Compile boost:signals2 only once
ClosedPublic
Actions

Authored by Fabien on Jan 23 2020, 13:39.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING15b098863667: ui: Compile boost:signals2 only once
rABC15b098863667: ui: Compile boost:signals2 only once
Summary
ui is one of the modules that poison other modules with boost/signals2
headers. This moves the include to the cpp file and uses a forward
declaration in the header.

Backport of core PR13634.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13634
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9117
Build 16193: Default Diff Build & Tests
Build 16192: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2020, 13:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2020, 13:39
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity edited the summary of this revision. (Show Details)Jan 23 2020, 13:39

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 23 2020, 13:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added inline comments.Jan 23 2020, 13:40
src/noui.cpp
11

Note to reviewers: this is a leftover from D4176 due to out-of-order backport.

teamcity added a comment.Jan 23 2020, 13:45

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9117: Diff 15757.Jan 23 2020, 13:45
Fabien added a child revision: D5052: gui: Also log and print messages or questions like bitcoind.Jan 23 2020, 14:00
jasonbcox accepted this revision.Jan 24 2020, 17:57
This revision is now accepted and ready to land.Jan 24 2020, 17:57
Closed by commit rABC15b098863667: ui: Compile boost:signals2 only once (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJan 24 2020, 20:53
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC15b098863667: ui: Compile boost:signals2 only once.
Fabien added a commit: rSTAGING15b098863667: ui: Compile boost:signals2 only once.Apr 7 2020, 22:38

Revision Contents
Changeset List

PathSize
src/
12 lines
interfaces/
22 lines
8 lines
60 lines
89 lines

Diff 15757

View Options

src/init.cpp

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/noui.cpp

Loading...
View Options

src/ui_interface.h

Loading...
View Options

src/ui_interface.cpp

Loading...