HomePhabricator

tests: Reduce noise level in test_bitcoin output

Description

tests: Reduce noise level in test_bitcoin output

Summary:
Backport of core PR15352.

The most interesting part here is the commit 5fd73c8:

Avoid repeated log messages in tests by connecting to signal handlers
(ThreadSafeMessageBox, etc.) only once

which will prevent from flooding the test_bitcoin output with a ton of
misleading wallet error messages (since D5004).

I extended the scope to a couple more tests that were printing a message
due to no assertion being run.

Note to reviewers: the changes to src/test/blockencodings_tests.cpp
does not apply to us (see D5049).

Test Plan:

ninja test_bitcoin
./test_bitcoin --log_level=message

Reviewers: #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D5050

Details

Committed
FabienJan 24 2020, 20:50
Pushed
FabienJan 24 2020, 20:50
Reviewer
Restricted Project
Differential Revision
D5050: tests: Reduce noise level in test_bitcoin output
Parents
rABC8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem::
Branches
Unknown
Tags
Unknown

Event Timeline