Page MenuHomePhabricator

tests: Reduce noise level in test_bitcoin output
ClosedPublic

Authored by Fabien on Jan 23 2020, 11:43.

Details

Summary

Backport of core PR15352.

The most interesting part here is the commit 5fd73c8:

Avoid repeated log messages in tests by connecting to signal handlers
(ThreadSafeMessageBox, etc.) only once

which will prevent from flooding the test_bitcoin output with a ton of
misleading wallet error messages (since D5004).

I extended the scope to a couple more tests that were printing a message
due to no assertion being run.

Note to reviewers: the changes to src/test/blockencodings_tests.cpp
does not apply to us (see D5049).

Test Plan
ninja test_bitcoin
./test_bitcoin --log_level=message

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 23 2020, 11:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2020, 11:43
teamcity edited the summary of this revision. (Show Details)Jan 23 2020, 11:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

jasonbcox accepted this revision.Jan 24 2020, 18:33
This revision is now accepted and ready to land.Jan 24 2020, 18:33