Page MenuHomePhabricator
Differential D5064

Add skeleton chain and client classes
ClosedPublic
Actions

Authored by Fabien on Jan 24 2020, 20:42.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGda2dd548a310: Add skeleton chain and client classes
rABCda2dd548a310: Add skeleton chain and client classes
Summary
This commit does not change behavior. It just adds new skeleton classes
that don't do anything and aren't instantiated yet.

Partial backport of core PR14437:
https://github.com/bitcoin/bitcoin/pull/14437/commits/7e2e62cf7c513bd7d8e784069c5534fda1c50c52

Depends on D5058.

Test Plan
ninja check
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14437_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9134
Build 16226: Default Diff Build & Tests
Build 16225: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 24 2020, 20:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2020, 20:42
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity edited the summary of this revision. (Show Details)Jan 24 2020, 20:42

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 24 2020, 20:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 24 2020, 20:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9134: Diff 15777.Jan 24 2020, 20:48
deadalnix edited the summary of this revision. (Show Details)Jan 25 2020, 16:00

I removed the edit from the bot as it was not appropriate - pointing to the whole PR when a perfectly good change was available.

deadalnix accepted this revision.Jan 25 2020, 16:02
This revision is now accepted and ready to land.Jan 25 2020, 16:02
Fabien added a child revision: D5074: Pass chain and client variables where needed.Jan 27 2020, 09:16
Closed by commit rABCda2dd548a310: Add skeleton chain and client classes (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyJan 27 2020, 16:04
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCda2dd548a310: Add skeleton chain and client classes.
Fabien mentioned this in D5093: Fix autotools build failure.Jan 28 2020, 21:12
Fabien mentioned this in rABC523d6d574e5d: Fix autotools build failure.Jan 28 2020, 21:31
Fabien added a commit: rSTAGINGda2dd548a310: Add skeleton chain and client classes.Apr 7 2020, 22:39
Fabien mentioned this in rSTAGING523d6d574e5d: Fix autotools build failure.

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
interfaces/
2 lines
43 lines
20 lines
21 lines

Diff 15777

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/interfaces/README.md

Loading...
View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...