[DOC] Update the depends README with dependencies and cmake instructions
ClosedPublic
Actions

Authored by Fabien on Mar 2 2020, 14:44.

Details

Reviewers

jasonbcox
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING3aaf582f6e7a: [DOC] Update the depends README with dependencies and cmake instructions
rABC3aaf582f6e7a: [DOC] Update the depends README with dependencies and cmake instructions

Summary

This diff updates the cross compilation instructions to use cmake and
ninja.
It also make the doc in sync with core with up to date dependencies.

Backport of core PR14264 and PR16051.

Test Plan

Read and test the instructions.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

doc_cmake_depends

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9698
Build 17289: Default Diff Build & Tests
Build 17288: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 2 2020, 14:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 2 2020, 14:44

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9680: Diff 16682.Mar 2 2020, 14:54

Fabien mentioned this in D5397: [DOC] Various updates to cmake/ninja.Mar 2 2020, 16:11

deadalnix added a subscriber: deadalnix.Mar 2 2020, 23:35

deadalnix added inline comments.

depends/README.md
58 ↗	(On Diff #16682)	???
92 ↗	(On Diff #16682)	Why change the order?

Fabien planned changes to this revision.Mar 3 2020, 07:13

Fabien added inline comments.

depends/README.md
58 ↗	(On Diff #16682)	There is no error, D854 still applies. I can look into this and try to find an option that remove the dependency, but it's out of scope.
92 ↗	(On Diff #16682)	Rebase issue, will fix.

Fix ordering.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9698: Diff 16719.Mar 3 2020, 07:26

Fabien mentioned this in rABCe7b7a0be4adf: [DOC] Various updates to cmake/ninja.Mar 3 2020, 07:37

jasonbcox requested changes to this revision.Mar 3 2020, 18:27

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

depends/README.md
97	This example uses make, but the next line references cmake. Either cleanup the wording for this whole paragraph or just don't reference make at all (use more general wording).

This revision now requires changes to proceed.Mar 3 2020, 18:27

jasonbcox added inline comments.Mar 3 2020, 18:29