Page MenuHomePhabricator

[SECP256K1] Add valgrind check to travis
ClosedPublic

Authored by Fabien on Mar 5 2020, 09:39.

Details

Summary
As discussed in #687
This adds valgrind check to the repo.

It doesn't run on recovery+ecdh because of the time.
No openssl because of uninitialized mem.
I debated between with and without ASM, but decided with ASM because it
might be more fragile(?).

I wasn't sure if I should pass -DVALGRIND via CFLAGS or CPPFLAGS, it
seems like because this is only C then there shouldn't even be CPPFLAGS
but looks like we use CPPFLAGS in other places for the preprocessor
definitions.

If people are worried about the time it takes we can mark it as
allow_failure although I don't think it's a problem here because there's
only a handful of PRs and they're usually open for weeks.

Backport of secp256k1 PR690.

Depends on D5429, D5430 and D5431.

Test Plan

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secp256k1_PR690
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9734
Build 17355: Default Diff Build & Tests
Build 17354: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Mar 5 2020, 16:58