Page MenuHomePhabricator
Differential D5527

Merge #14291: wallet: Add ListWalletDir utility function
ClosedPublic
Actions

Authored by nakihito on Mar 20 2020, 21:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING50a1fbc83f20: Merge #14291: wallet: Add ListWalletDir utility function
rABC50a1fbc83f20: Merge #14291: wallet: Add ListWalletDir utility function
Summary

d56a0689354fb814510c6c393f3e07ac9362dc1f docs: Add release notes for listwalletdir RPC (João Barbosa)
0cb3cad166bbeb75e9cc1512286453f8e7d4f717 qa: Add tests for listwalletdir RPC (João Barbosa)
cc3377360c417780f5cbd7bd69b438817a9d60be rpc: Add listwalletdir RPC (João Barbosa)
d1b03b8e5f04a2cc9ebb985bd9a1aebd2068f757 interfaces: Add getWalletDir and listWalletDir to Node (João Barbosa)
fc4db35bfd78d85d6b52d5da3d89696160658450 wallet: Add ListWalletDir utility (João Barbosa)

Pull request description:

`ListWalletDir` returns all available wallets in the current wallet directory.

Based on MeshCollider work in pull #11485.

Tree-SHA512: 5843e3dbd1e0449f55bb8ea7c241a536078ff6ffcaad88ce5fcf8963971d48c78600fbc4f44919523b8a92329d5d8a5f567a3e0ccb0270fdd27366e19603a716

Backport of Core PR14291

Test Plan
ninja
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help

Verify listwalletdir appears in the list of Wallet RPCs.

./bitcoin-cli help listwalletdir
./bitcoin-cli listwalletdir

Verify new RPC help text and behavior.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14291
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9907
Build 17673: Default Diff Build & Tests
Build 17672: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 20 2020, 21:27
Owners added a reviewer: Restricted Owners Package.Mar 20 2020, 21:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 20 2020, 21:27
teamcity edited the summary of this revision. (Show Details)Mar 20 2020, 21:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 20 2020, 21:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito added inline comments.Mar 20 2020, 21:31
src/wallet/walletutil.cpp
7–8

Ditto.

src/wallet/walletutil.h
8

This is the equivalent of Core's util.h at the time of the merge request.

teamcity added a comment.Mar 20 2020, 21:38

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9907: Diff 17080.Mar 20 2020, 21:38
nakihito updated this revision to Diff 17081.Mar 20 2020, 22:19

Fixed some formatting issues.

teamcity added a comment.Mar 20 2020, 22:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 20 2020, 22:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9908: Diff 17081.Mar 20 2020, 22:28
deadalnix accepted this revision.Mar 21 2020, 00:20
This revision is now accepted and ready to land.Mar 21 2020, 00:20
Closed by commit rABC50a1fbc83f20: Merge #14291: wallet: Add ListWalletDir utility function (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyMar 21 2020, 00:46
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC50a1fbc83f20: Merge #14291: wallet: Add ListWalletDir utility function.
nakihito added a reverting change: D5534: Revert "Merge #14291: wallet: Add ListWalletDir utility function".Mar 21 2020, 17:25
jasonbcox mentioned this in D5535: Add another UBSAN vptr suppression.Mar 22 2020, 23:36
jasonbcox mentioned this in rABC3eb3dcb04558: Add another UBSAN vptr suppression.Mar 23 2020, 04:01
nakihito added a commit: rSTAGING50a1fbc83f20: Merge #14291: wallet: Add ListWalletDir utility function.Apr 7 2020, 23:25
jasonbcox mentioned this in rSTAGING3eb3dcb04558: Add another UBSAN vptr suppression.Apr 7 2020, 23:25

Revision Contents
Changeset List

PathSize
doc/
5 lines
src/
8 lines
interfaces/
6 lines
10 lines
wallet/
32 lines
7 lines
55 lines
test/
functional/
12 lines

Diff 17080

View Options

doc/release-notes.md

Loading...
View Options

src/dummywallet.cpp

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/walletutil.h

Loading...
View Options

src/wallet/walletutil.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...