Differential D709

Support cashaddr in parse/format URI
ClosedPublic
Actions

Authored by dagurval on Nov 23 2017, 14:58.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING9350110492c6: Support cashaddr in parse/format URI
rABC9350110492c6: Support cashaddr in parse/format URI

Summary

Depends on D708

Test Plan

added tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

23-11-parseformat

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1160
Build 1160: arc lint + arc unit

Event Timeline

dagurval created this revision.Nov 23 2017, 14:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2017, 14:58

dagurval edited the summary of this revision. (Show Details)Nov 23 2017, 14:58

dagurval added a parent revision: D708: Make Config more available in Qt.

deadalnix requested changes to this revision.Nov 23 2017, 15:11

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/qt/guiutil.cpp
177	This should be able to detect which kind of addresses we are looking at rather than blindly trusting the config.
src/qt/test/uritests.cpp
26	This whole test should work with and without cashaddr enabled.
99	dito
200

This revision now requires changes to proceed.Nov 23 2017, 15:11

Check if URI is cashaddr encoded instead of relying on user config

This should be able to detect which kind of addresses we are looking at rather than blindly trusting the config.

Good idea. This simplifies this change also, since cfg no longer has to be passed to parseBitcoinURI

dagurval mentioned this in D583: Support parsing cashaddr from command line.Nov 27 2017, 13:28

dagurval added a child revision: D583: Support parsing cashaddr from command line.Nov 27 2017, 13:31

Back on your queue

This revision now requires changes to proceed.Nov 29 2017, 21:04

deadalnix accepted this revision.Nov 30 2017, 15:56

This revision is now accepted and ready to land.Nov 30 2017, 15:56

Closed by commit rABC9350110492c6: Support cashaddr in parse/format URI (authored by dagurval). · Explain WhyDec 6 2017, 21:58

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in D765: Revert support cashaddr in parse/format URI.Dec 7 2017, 00:12

Revision Contents
Changeset List

Path

Size

src/

qt/

7 lines

22 lines

2 lines

16 lines

receivecoinsdialog.cpp

2 lines

receiverequestdialog.cpp

4 lines

test/

uritests.h

4 lines

uritests.cpp

147 lines

Diff 1817

View Options

src/qt/guiutil.h

View Options

src/qt/guiutil.cpp

View Options

src/qt/openuridialog.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/receivecoinsdialog.cpp

View Options

src/qt/receiverequestdialog.cpp

View Options

src/qt/test/uritests.h

View Options

Support cashaddr in parse/format URIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1817

src/qt/guiutil.h

src/qt/guiutil.cpp

src/qt/openuridialog.cpp

src/qt/paymentserver.cpp

src/qt/receivecoinsdialog.cpp

src/qt/receiverequestdialog.cpp

src/qt/test/uritests.h

src/qt/test/uritests.cpp

Support cashaddr in parse/format URI
ClosedPublic
Actions

Revision Contents
Changeset List