Page MenuHomePhabricator
Differential D725

Use CService instead of CSeederService
ClosedPublic
Actions

Authored by deadalnix on Nov 26 2017, 21:01.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGb5bcef69171f: Use CService instead of CSeederService
rABCb5bcef69171f: Use CService instead of CSeederService
Summary

More code deduplication between the seeder and the rest.

Test Plan

Build the seeder
Run the seeder.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sedderservice
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1182
Build 1182: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 26 2017, 21:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2017, 21:01
Harbormaster completed remote builds in B1182: Diff 1845.Nov 26 2017, 21:01
deadalnix added a child revision: D726: Rename CMessageHeader in the seeder into CSeederMessageHeader.Nov 27 2017, 01:39
deadalnix added parent revisions: D723: Remove CInv from the seeder, D722: Remove redundant libraries linked in the seeder, D719: Move seeder specific protocol parts in their own file..
schancel requested changes to this revision.Dec 2 2017, 04:12

No longer applies cleanly on master.

src/seeder/main.cpp
453

What was this for?

This revision now requires changes to proceed.Dec 2 2017, 04:12
deadalnix updated this revision to Diff 1902.Dec 3 2017, 16:01

rebase

Harbormaster completed remote builds in B1224: Diff 1902.Dec 3 2017, 16:01
schancel accepted this revision.Dec 3 2017, 18:30
This revision is now accepted and ready to land.Dec 3 2017, 18:30
Closed by commit rABCb5bcef69171f: Use CService instead of CSeederService (authored by deadalnix). · Explain WhyDec 3 2017, 18:36
This revision was automatically updated to reflect the committed changes.
schancel mentioned this in D726: Rename CMessageHeader in the seeder into CSeederMessageHeader.Dec 3 2017, 19:05
nakihito mentioned this in D4259: Remove strlcpy.h.Oct 16 2019, 00:27
Nico Guiton <nico@bitframe.org> mentioned this in rABC995338aa7108: Remove strlcpy.h.Oct 16 2019, 17:48
nakihito mentioned this in rSTAGING995338aa7108: Remove strlcpy.h.Apr 7 2020, 21:26

Revision Contents
Changeset List

PathSize
src/
seeder/
6 lines
6 lines
5 lines
9 lines
40 lines
16 lines
19 lines
57 lines
273 lines

Diff 1845

View Options

src/seeder/address.h

Loading...
View Options

src/seeder/address.cpp

Loading...
View Options

src/seeder/bitcoin.h

Loading...
View Options

src/seeder/bitcoin.cpp

Loading...
View Options

src/seeder/db.h

Loading...
View Options

src/seeder/db.cpp

Loading...
View Options

src/seeder/main.cpp

Loading...
View Options

src/seeder/netbase.h

Loading...
View Options

src/seeder/netbase.cpp

Loading...