Page MenuHomePhabricator

Allow to extend and override the sanitizers options
ClosedPublic

Authored by Fabien on Apr 10 2020, 14:52.

Details

Summary

This cause the values from the user environment to be appended to the
options, allowing for adding options or overriding some. Update the CI
to use this feature.

Depends on D5689.

Test Plan

Run the build-asan, build-ubsan and build-tsan CI builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sanitizer_options_override
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10166
Build 18158: Default Diff Build & Tests
Build 18157: arc lint + arc unit

Event Timeline

jasonbcox added inline comments.
contrib/teamcity/build-configurations.sh
42

Where do these logs default to when log_path is not set? stdout?

contrib/teamcity/build-configurations.sh
42

Yes to stdout

jasonbcox added inline comments.
contrib/teamcity/build-configurations.sh
42

Consider renaming these to ADDITIONAL_xSAN_OPTIONS to make it clear that these are not the only options being applied.

This revision is now accepted and ready to land.Apr 10 2020, 17:16
contrib/teamcity/build-configurations.sh
42

The option name is defined by the sanitizers. This also allow to override the value from the build system if desired.