Page MenuHomePhabricator
Differential D5737

Split DecodePSBT into Base64 and Raw versions
ClosedPublic
Actions

Authored by Fabien on Apr 15 2020, 11:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8eef3ca0f3c7: Split DecodePSBT into Base64 and Raw versions
rABC8eef3ca0f3c7: Split DecodePSBT into Base64 and Raw versions
Summary
Split up DecodePSBT, which both decodes base64 and then deserializes a
PartiallySignedTransaction, into two functions: DecodeBase64PSBT, which
retains the old behavior, and DecodeRawPSBT, which only performs the
deserialization.

Add a test for base64 decoding failure.

Partial backport of core PR14978:
https://github.com/bitcoin/bitcoin/pull/14978/commits/c734aaa15d924470cec0f17b00ad2e47472b471f

Depends on D5736.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14978_part4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10229
Build 18282: Default Diff Build & Tests
Build 18281: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 15 2020, 11:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2020, 11:44
teamcity edited the summary of this revision. (Show Details)Apr 15 2020, 11:44

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 15 2020, 11:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 15 2020, 12:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10229: Diff 18824.Apr 15 2020, 12:04
deadalnix accepted this revision.Apr 15 2020, 15:46
This revision is now accepted and ready to land.Apr 15 2020, 15:46
Closed by commit rABC8eef3ca0f3c7: Split DecodePSBT into Base64 and Raw versions (authored by Glenn Willen <gwillen@nerdnet.org>, committed by Fabien). · Explain WhyApr 16 2020, 13:31
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8eef3ca0f3c7: Split DecodePSBT into Base64 and Raw versions.
Fabien added a commit: rSTAGING8eef3ca0f3c7: Split DecodePSBT into Base64 and Raw versions.May 5 2020, 18:59

Revision Contents
Changeset List

PathSize
src/
9 lines
19 lines
rpc/
6 lines
wallet/
2 lines
test/
functional/
6 lines

Diff 18824

View Options

src/core_io.h

Loading...
View Options

src/core_read.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/rpc_psbt.py

Loading...