Page MenuHomePhabricator
Differential D5888

Preparations for more testchains
ClosedPublic
Actions

Authored by deadalnix on Apr 29 2020, 15:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGcf6846fa785e: Preparations for more testchains
rABCcf6846fa785e: Preparations for more testchains
Summary
  • Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest
  • Testchains: Qt: Simplify network/chain styles

This is a backport of Core PR16680

Depends on D5887

Test Plan
make check

Run bitcoin-qt on win64

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16680
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10499
Build 18816: Default Diff Build & Tests
Build 18815: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 29 2020, 15:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2020, 15:31
teamcity edited the summary of this revision. (Show Details)Apr 29 2020, 15:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix edited the summary of this revision. (Show Details)Apr 29 2020, 15:31
deadalnix added a parent revision: D5887: gui: Fix for Incorrect application name when passing -regtest.
teamcity added a comment.Apr 29 2020, 15:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 29 2020, 15:57

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10475: Diff 19244.Apr 29 2020, 15:57
Fabien requested changes to this revision.Apr 29 2020, 19:03
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/chainparamsbase.cpp
26 ↗(On Diff #19244)

The Equivalent to -chain=regtest mention is missing

29 ↗(On Diff #19244)

Dito

src/util/system.cpp
1115 ↗(On Diff #19244)

Nit: Use C++ constructor

This revision now requires changes to proceed.Apr 29 2020, 19:03
deadalnix updated this revision to Diff 19263.Apr 29 2020, 21:26

Address comments

teamcity added a comment.Apr 29 2020, 21:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 29 2020, 21:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10488: Diff 19263.Apr 29 2020, 21:44
Fabien requested changes to this revision.Apr 30 2020, 07:25
Fabien added inline comments.
src/chainparamsbase.cpp
27 ↗(On Diff #19263)

It's regtest here, not testnet

This revision now requires changes to proceed.Apr 30 2020, 07:25
deadalnix updated this revision to Diff 19281.Apr 30 2020, 11:34

regtest

teamcity added a comment.Apr 30 2020, 11:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien accepted this revision.Apr 30 2020, 11:36
This revision is now accepted and ready to land.Apr 30 2020, 11:36
teamcity added a comment.Apr 30 2020, 11:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10499: Diff 19281.Apr 30 2020, 11:44
Closed by commit rABCcf6846fa785e: Preparations for more testchains (authored by Jorge Timón <jtimon@jtimon.cc>, committed by deadalnix). · Explain WhyApr 30 2020, 11:45
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCcf6846fa785e: Preparations for more testchains.
deadalnix added a commit: rSTAGINGcf6846fa785e: Preparations for more testchains.May 5 2020, 19:14

Revision Contents
Changeset List

PathSize
src/
4 lines
4 lines
4 lines
21 lines
qt/
8 lines
9 lines
5 lines
17 lines
test/
4 lines
test/
2 lines
util/
13 lines
test/
lint/
12 lines

Diff 19281

View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/bitcoind.cpp

Loading...
View Options

src/chainparamsbase.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/networkstyle.h

Loading...
View Options

src/qt/networkstyle.cpp

Loading...
View Options

src/qt/test/apptests.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/system.cpp

Loading...
View Options

test/lint/check-doc.py

Loading...