Page MenuHomePhabricator

Preparations for more testchains
ClosedPublic

Authored by deadalnix on Apr 29 2020, 15:31.

Details

Summary
  • Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest
  • Testchains: Qt: Simplify network/chain styles

This is a backport of Core PR16680

Depends on D5887

Test Plan
make check

Run bitcoin-qt on win64

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16680
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10499
Build 18816: Default Diff Build & Tests
Build 18815: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Apr 29 2020, 19:03
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/chainparamsbase.cpp
26 ↗(On Diff #19244)

The Equivalent to -chain=regtest mention is missing

29 ↗(On Diff #19244)

Dito

src/util/system.cpp
1115 ↗(On Diff #19244)

Nit: Use C++ constructor

This revision now requires changes to proceed.Apr 29 2020, 19:03
Fabien requested changes to this revision.Apr 30 2020, 07:25
Fabien added inline comments.
src/chainparamsbase.cpp
27 ↗(On Diff #19263)

It's regtest here, not testnet

This revision now requires changes to proceed.Apr 30 2020, 07:25
This revision is now accepted and ready to land.Apr 30 2020, 11:36
This revision was automatically updated to reflect the committed changes.