Details

Reviewers

deadalnix
freetrader
mbhinder

Group Reviewers

Restricted Project

Commits

rSTAGING970e4b5d9c4e: Convert BitcoinAmountField to use Amount class
rABC970e4b5d9c4e: Convert BitcoinAmountField to use Amount class

Summary

Depends on D747

Test Plan

make check
run src/qt/bitcoin-qt --testnet and try sending and receiving some transactions.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

qt-moc-field

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1245
Build 1245: arc lint + arc unit

Event Timeline

schancel created this revision.Dec 4 2017, 06:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2017, 06:51

Remove erroneous comment

Harbormaster completed remote builds in B1237: Diff 1925.Dec 4 2017, 07:01

I do not think make check actually verify the GUI. Running the GUI on testnet and making a transaction there seems like a more appropriate test plan.

deadalnix requested changes to this revision.Dec 4 2017, 18:38

This revision now requires changes to proceed.Dec 4 2017, 18:38

It does run test_bitcoin-qt:

PASS: qt/test/test_bitcoin-qt

But you're right that it probably doesn't cover much. I'll see what I can do.

Updating test plan

schancel edited the test plan for this revision. (Show Details)Dec 5 2017, 02:37

deadalnix accepted this revision.Dec 5 2017, 13:03

This revision is now accepted and ready to land.Dec 5 2017, 13:03

Rebase

Harbormaster completed remote builds in B1255: Diff 1949.Dec 6 2017, 01:42

schancel edited the summary of this revision. (Show Details)Dec 6 2017, 16:26

schancel added a parent revision: D735: Prepare BitcoinUnits for explicit Amount construction.

schancel added a child revision: D759: Convert overviewpage to use Amount class.

schancel edited the summary of this revision. (Show Details)Dec 7 2017, 01:33

schancel added a parent revision: D747: Convert bitcoinunits to use Amount class.

Closed by commit rABC970e4b5d9c4e: Convert BitcoinAmountField to use Amount class (authored by schancel). · Explain WhyDec 7 2017, 01:39

This revision was automatically updated to reflect the committed changes.

Convert BitcoinAmountField to use Amount class
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1938

src/qt/bitcoin.cpp

src/qt/bitcoinamountfield.h

src/qt/bitcoinamountfield.cpp

src/qt/receivecoinsdialog.cpp

src/qt/sendcoinsdialog.cpp

src/qt/sendcoinsentry.cpp

Convert BitcoinAmountField to use Amount classClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1938

src/qt/bitcoin.cpp

src/qt/bitcoinamountfield.h

src/qt/bitcoinamountfield.cpp

src/qt/receivecoinsdialog.cpp

src/qt/sendcoinsdialog.cpp

src/qt/sendcoinsentry.cpp

Convert BitcoinAmountField to use Amount class
ClosedPublic
Actions

Revision Contents
Changeset List