Page MenuHomePhabricator
Differential D756

Fix MacOS X build
ClosedPublic
Actions

Authored by schancel on Dec 5 2017, 23:31.

Details

Reviewers
deadalnix
freetrader
Group Reviewers
Restricted Project
Commits
rSTAGING6c562f1eb524: Fix MacOS X build
rABC6c562f1eb524: Fix MacOS X build
Summary

Re-add includes for uint256.cpp and uint256.h into libbitcoin_consensus.a

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1251
Build 1251: arc lint + arc unit

Event Timeline

schancel created this revision.Dec 5 2017, 23:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 5 2017, 23:31
Harbormaster completed remote builds in B1251: Diff 1945.Dec 5 2017, 23:31
deadalnix added a comment.Dec 6 2017, 01:59

This causes uint256 to be linked in twice when using consensus and util libraries. This is a problem.

schancel added a comment.Dec 6 2017, 15:53

Fact. Can you please suggest an alternative?

schancel planned changes to this revision.Dec 6 2017, 16:39

Need to figure out how to deal with the need for these symbols in both libraries without including them twice.

schancel requested review of this revision.Dec 7 2017, 01:20
deadalnix accepted this revision.Dec 7 2017, 01:21
This revision is now accepted and ready to land.Dec 7 2017, 01:21
Closed by commit rABC6c562f1eb524: Fix MacOS X build (authored by schancel). · Explain WhyDec 7 2017, 01:36
This revision was automatically updated to reflect the committed changes.
schancel mentioned this in T114: Build broken on MacOS X.Dec 10 2017, 18:52

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 1945

View Options

src/Makefile.am

Loading...