Because there is one more negative value possible than positive value, this code does not handle LONG_MIN properly. The obvious solution is to consider the absolute value unsigned (duh!).
Details
Details
- Reviewers
jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING28858edca4e5: Properly handle LONG_MIN in timedata.cpp
rABC28858edca4e5: Properly handle LONG_MIN in timedata.cpp
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- unsignedabs64
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 10675 Build 19147: Default Diff Build & Tests Build 19146: arc lint + arc unit