Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys
ClosedPublic
Actions

Authored by nakihito on May 13 2020, 18:18.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa6b244747e9c: Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys
rABCa6b244747e9c: Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys

Summary

98ea64cf232c34d4b1aebe738b3956191667cd76 Let wallet importmulti RPC accept labels for standard scriptPubKeys (Russell Yanofsky)

Pull request description:

Allow importmulti RPC to apply address labels when importing standard scriptPubKeys. This makes the importmulti RPC less finnicky about import formats and also simpler internally.

Tree-SHA512: 102426b21239f1fa5f38162dc3f4145572caef76e63906afd786b7aff1670d6cd93456f8d85f737588eedc49c11bef2e1e8019b8b2cbf6097c77b3501b0cab1f

Backport of Core PR9332
I also had to reapply a change from PR14679

Test Plan

ninja
ninja check
ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.May 13 2020, 18:18

Owners added a reviewer: Restricted Owners Package.May 13 2020, 18:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2020, 18:18

nakihito requested review of this revision.May 13 2020, 18:18

nakihito planned changes to this revision.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

nakihito requested review of this revision.May 13 2020, 18:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10746: Diff 20013.May 13 2020, 18:30

nakihito mentioned this in D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).May 13 2020, 18:31

nakihito added a child revision: D6051: Partial Merge #14454: ProcessImport() cleanup (excluding witness).May 13 2020, 19:43

nakihito added inline comments.May 14 2020, 20:09

src/wallet/rpcdump.cpp
1373 ↗	(On Diff #20013)	This is a reapplication of https://github.com/bitcoin/bitcoin/pull/14679/files#diff-522490d83dce5375d423b23886e4125eR997-R999.