Details

Reviewers

deadalnix
freetrader

Group Reviewers

Restricted Project

Commits

rSTAGINGef1001a484d2: Prepare SendCoinsDialog for explicit Amount construction
rABCef1001a484d2: Prepare SendCoinsDialog for explicit Amount construction

Test Plan

make check
Run Qt GUI

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fixish-qt-amount

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1320
Build 1320: arc lint + arc unit

Event Timeline

schancel created this revision.Dec 11 2017, 17:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2017, 17:05

Harbormaster completed remote builds in B1318: Diff 2037.Dec 11 2017, 17:05

Prepare walletmodel and walletmodeltransaction for explicit Amounts

Harbormaster completed remote builds in B1319: Diff 2038.Dec 11 2017, 17:25

Prepare the remainder of Bitcoin-Qt for explicit Amount construction

Harbormaster completed remote builds in B1320: Diff 2039.Dec 11 2017, 17:58

Need to fix the diffs.

Rebasing and attempting to stack diffs

schancel added a child revision: D788: Prepare walletmodel* for explicit Amount construction.Dec 11 2017, 19:08

deadalnix accepted this revision.Dec 11 2017, 20:41

This revision is now accepted and ready to land.Dec 11 2017, 20:41

Closed by commit rABCef1001a484d2: Prepare SendCoinsDialog for explicit Amount construction (authored by schancel). · Explain WhyDec 12 2017, 14:22

This revision was automatically updated to reflect the committed changes.

Prepare SendCoinsDialog for explicit Amount construction
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 2039

src/qt/bitcoin.cpp

src/qt/bitcoinamountfield.cpp

src/qt/bitcoingui.h

src/qt/bitcoingui.cpp

src/qt/coincontroldialog.h

src/qt/coincontroldialog.cpp

src/qt/guiutil.cpp

src/qt/paymentrequestplus.h

src/qt/paymentrequestplus.cpp

src/qt/paymentserver.h

src/qt/paymentserver.cpp

src/qt/receivecoinsdialog.cpp

src/qt/receiverequestdialog.cpp

src/qt/sendcoinsdialog.h

src/qt/sendcoinsdialog.cpp

src/qt/sendcoinsentry.cpp

src/qt/test/paymentservertests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionfilterproxy.h

src/qt/transactionfilterproxy.cpp

src/qt/transactionrecord.h

src/qt/transactionrecord.cpp

src/qt/transactiontablemodel.cpp

src/qt/transactionview.cpp

src/qt/walletmodel.h

src/qt/walletmodel.cpp

src/qt/walletmodeltransaction.h

src/qt/walletmodeltransaction.cpp

src/qt/walletview.h

src/qt/walletview.cpp

Prepare SendCoinsDialog for explicit Amount constructionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2039

src/qt/bitcoin.cpp

src/qt/bitcoinamountfield.cpp

src/qt/bitcoingui.h

src/qt/bitcoingui.cpp

src/qt/coincontroldialog.h

src/qt/coincontroldialog.cpp

src/qt/guiutil.cpp

src/qt/paymentrequestplus.h

src/qt/paymentrequestplus.cpp

src/qt/paymentserver.h

src/qt/paymentserver.cpp

src/qt/receivecoinsdialog.cpp

src/qt/receiverequestdialog.cpp

src/qt/sendcoinsdialog.h

src/qt/sendcoinsdialog.cpp

src/qt/sendcoinsentry.cpp

src/qt/test/paymentservertests.cpp

src/qt/transactiondesc.cpp

src/qt/transactionfilterproxy.h

src/qt/transactionfilterproxy.cpp

src/qt/transactionrecord.h

src/qt/transactionrecord.cpp

src/qt/transactiontablemodel.cpp

src/qt/transactionview.cpp

src/qt/walletmodel.h

src/qt/walletmodel.cpp

src/qt/walletmodeltransaction.h

src/qt/walletmodeltransaction.cpp

src/qt/walletview.h

src/qt/walletview.cpp

Prepare SendCoinsDialog for explicit Amount construction
ClosedPublic
Actions

Revision Contents
Changeset List