Paths

Table of Contentst

Differential D790

Complete explicit Amount construction in Qt code
ClosedPublic
Actions

Authored by schancel on Dec 11 2017, 19:10.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING4ffc5b345907: Complete explicit Amount construction in Qt code
rABC4ffc5b345907: Complete explicit Amount construction in Qt code

Summary

Explicitly construct Amount types.

Depends on D789.

Test Plan

make check
Run QT GUI

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1325
Build 1325: arc lint + arc unit

Event Timeline

schancel created this revision.Dec 11 2017, 19:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2017, 19:10

Harbormaster completed remote builds in B1325: Diff 2044.Dec 11 2017, 19:10

schancel added a child revision: D721: Set Amount constructor to explicit.Dec 11 2017, 19:12

deadalnix requested changes to this revision.Dec 11 2017, 19:43

deadalnix added inline comments.

src/qt/bitcoinamountfield.cpp
138	Amount val(0);
src/qt/paymentrequestplus.cpp
229	Make that thing return an amount.
src/qt/walletmodel.cpp
179	Amount total(0);
198	dito
204	Make this amount function return an amount.
src/qt/walletview.cpp
195	One would expect amount to be an amount.

This revision now requires changes to proceed.Dec 11 2017, 19:43

schancel added inline comments.Dec 11 2017, 19:45

src/qt/paymentrequestplus.cpp
229	It looks like it's protobufs stuff. I looked into it.

payments:: stuff is coming from protobufs definitions.`. I'm not sure about adding Amount class to that.

// Generalized form of "send payment to this/these bitcoin cash addresses"
message Output {
	optional uint64 amount = 1 [default = 0]; // amount is integer-number-of-satoshis
	required bytes script = 2; // usually one of the standard Script forms
}

Address nits

deadalnix accepted this revision.Dec 11 2017, 23:48

deadalnix added inline comments.

src/qt/paymentrequestplus.cpp
229	ok

This revision is now accepted and ready to land.Dec 11 2017, 23:48

Closed by commit rABC4ffc5b345907: Complete explicit Amount construction in Qt code (authored by schancel). · Explain WhyDec 12 2017, 14:34

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoinamountfield.cpp

4 lines

3 lines

coincontroldialog.cpp

41 lines

4 lines

overviewpage.cpp

12 lines

paymentrequestplus.cpp

2 lines

paymentserver.cpp

2 lines

receiverequestdialog.cpp

2 lines

recentrequeststablemodel.cpp

3 lines

sendcoinsdialog.cpp

15 lines

sendcoinsentry.cpp

2 lines

test/

20 lines

transactiondesc.cpp

4 lines

transactionfilterproxy.cpp

4 lines

transactionrecord.cpp

4 lines

transactiontablemodel.cpp

3 lines

transactionview.cpp

2 lines

walletmodel.cpp

18 lines

2 lines

Diff 2044

src/qt/bitcoinamountfield.cpp

Loading...

src/qt/bitcoingui.cpp

Loading...

src/qt/coincontroldialog.cpp

Loading...

src/qt/guiutil.cpp

Loading...

src/qt/overviewpage.cpp

Loading...

src/qt/paymentrequestplus.cpp

Loading...

src/qt/paymentserver.cpp

Loading...

src/qt/receiverequestdialog.cpp

Loading...

src/qt/recentrequeststablemodel.cpp

Loading...

src/qt/sendcoinsdialog.cpp

Loading...

src/qt/sendcoinsentry.cpp

Loading...

src/qt/test/uritests.cpp

Loading...

src/qt/transactiondesc.cpp

Loading...

src/qt/transactionfilterproxy.cpp

Loading...

src/qt/transactionrecord.cpp

Loading...

src/qt/transactiontablemodel.cpp

Loading...

src/qt/transactionview.cpp

Loading...

src/qt/walletmodel.cpp

Loading...

src/qt/walletview.cpp

Loading...