Details

Reviewers

deadalnix
freetrader
mbhinder

Group Reviewers

Restricted Project

Commits

rSTAGING5b699cd8cbeb: Set Amount constructor to explicit
rABC5b699cd8cbeb: Set Amount constructor to explicit

Summary

Depends on D790

Test Plan

make check
Run QT gui

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1326
Build 1326: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 26 2017, 17:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2017, 17:13

deadalnix accepted this revision.Nov 26 2017, 17:43

This revision is now accepted and ready to land.Nov 26 2017, 17:43

Rebasing on top of a few fixes

This depends on https://reviews.bitcoinabc.org/D735 due to an oversight on my part.

This needs several other patches to QT to go in before it can be landed now.

Rebase

This revision is now accepted and ready to land.Dec 11 2017, 19:11

schancel edited the summary of this revision. (Show Details)Dec 11 2017, 19:12

schancel edited the test plan for this revision. (Show Details)

schancel added a parent revision: D790: Complete explicit Amount construction in Qt code.

Rebase

Harbormaster completed remote builds in B1330: Diff 2053.Dec 11 2017, 19:50

Closed by commit rABC5b699cd8cbeb: Set Amount constructor to explicit (authored by schancel). · Explain WhyDec 12 2017, 14:37

This revision was automatically updated to reflect the committed changes.

Set Amount constructor to explicit
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 2045

src/amount.h

src/amount.cpp

Set Amount constructor to explicitClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2045

src/amount.h

src/amount.cpp

Set Amount constructor to explicit
ClosedPublic
Actions

Revision Contents
Changeset List