Page MenuHomePhabricator
Differential D6195

[refactor] Use DescriptorImpl internally, permitting access to new methods
ClosedPublic
Actions

Authored by deadalnix on May 21 2020, 14:36.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC752d0621de64: [refactor] Use DescriptorImpl internally, permitting access to new methods
Summary

This is a partial backport of Core PR14646 : https://github.com/bitcoin/bitcoin/pull/14646/commits/24d3a7b3a9e81c04505d130eb7e41885eda9d35f

Depends on D6194

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.May 21 2020, 14:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 14:36
deadalnix requested review of this revision.May 21 2020, 14:36
teamcity edited the summary of this revision. (Show Details)May 21 2020, 14:36

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 21 2020, 14:36

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 14:36

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 14:36

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 14:38

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 14:39

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 14:48

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10938: Diff 20452.May 21 2020, 14:48
deadalnix updated this revision to Diff 20457.May 21 2020, 14:52

rebase

deadalnix added a child revision: D6196: [refactor] Combine the ToString and ToPrivateString implementations.May 21 2020, 14:54
teamcity added a comment.May 21 2020, 15:05

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 15:06

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 15:07

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 15:07

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

majcosta added a subscriber: majcosta.May 21 2020, 15:09
teamcity added a comment.May 21 2020, 15:09

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

majcosta accepted this revision.May 21 2020, 15:14

you linked the wrong commit on the summary, here: https://github.com/bitcoin/bitcoin/pull/14646/commits/24d3a7b3a9e81c04505d130eb7e41885eda9d35f

This revision is now accepted and ready to land.May 21 2020, 15:14
deadalnix edited the summary of this revision. (Show Details)May 21 2020, 15:15
teamcity added a comment.May 21 2020, 15:16

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10939: Diff 20457.May 21 2020, 15:17
Closed by commit rABC752d0621de64: [refactor] Use DescriptorImpl internally, permitting access to new methods (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyMay 21 2020, 15:19
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC752d0621de64: [refactor] Use DescriptorImpl internally, permitting access to new methods.

Revision Contents
Changeset List

PathSize
src/
script/
21 lines

Diff 20457

View Options

src/script/descriptor.cpp

Loading...