Page MenuHomePhabricator
Differential D6218

rpc: Document default values for optional arguments
ClosedPublic
Actions

Authored by deadalnix on May 22 2020, 00:02.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5a5256baa9ab: rpc: Document default values for optional arguments
Summary

This is a backport of Core PR14877

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.May 22 2020, 00:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 00:02
deadalnix requested review of this revision.May 22 2020, 00:02
teamcity edited the summary of this revision. (Show Details)May 22 2020, 00:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 22 2020, 00:02

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 00:02

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 00:02

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 00:06

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 22 2020, 00:06

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 00:15

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10968: Diff 20503.May 22 2020, 00:15
Fabien requested changes to this revision.May 22 2020, 07:41
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/misc.cpp
386

This line should be removed

src/rpc/rawtransaction.cpp
473

Remove replaceable

1539

Dito

src/wallet/rpcdump.cpp
1666

Revert the doc, this sentence has been added after the PR you're backporting: D6140, https://github.com/bitcoin/bitcoin/pull/14565

1677

Dito

This revision now requires changes to proceed.May 22 2020, 07:41
deadalnix added inline comments.May 22 2020, 14:08
src/rpc/misc.cpp
386

Yeah, it's redundant indeed.

deadalnix updated this revision to Diff 20511.May 22 2020, 14:12

Address comments

teamcity added a comment.May 22 2020, 14:12

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 14:12

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 14:12

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 14:14

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 14:18

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 22 2020, 14:24

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10969: Diff 20511.May 22 2020, 14:24
Fabien accepted this revision.May 22 2020, 14:48
This revision is now accepted and ready to land.May 22 2020, 14:48
Closed by commit rABC5a5256baa9ab: rpc: Document default values for optional arguments (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyMay 22 2020, 14:50
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC5a5256baa9ab: rpc: Document default values for optional arguments.

Revision Contents
Changeset List

PathSize
src/
rpc/
10 lines
6 lines
10 lines
25 lines
25 lines
3 lines
2 lines
wallet/
16 lines
115 lines

Diff 20503

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...