Differential D6218

rpc: Document default values for optional arguments
ClosedPublic
Actions

Authored by deadalnix on May 22 2020, 00:02.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC5a5256baa9ab: rpc: Document default values for optional arguments

Summary

This is a backport of Core PR14877

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr14877

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10969
Build 20148: Default Diff Build & Tests
Build 20147: Build without Wallet
Build 20146: Build with clang-10
Build 20145: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 22 2020, 00:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 00:02

deadalnix requested review of this revision.May 22 2020, 00:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10968: Diff 20503.May 22 2020, 00:15

Fabien requested changes to this revision.May 22 2020, 07:41

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/rpc/misc.cpp
386 ↗	(On Diff #20503)	This line should be removed
src/rpc/rawtransaction.cpp
473 ↗	(On Diff #20503)	Remove replaceable
1539 ↗	(On Diff #20503)	Dito
src/wallet/rpcdump.cpp
1666 ↗	(On Diff #20503)	Revert the doc, this sentence has been added after the PR you're backporting: D6140, https://github.com/bitcoin/bitcoin/pull/14565
1677 ↗	(On Diff #20503)	Dito

This revision now requires changes to proceed.May 22 2020, 07:41

deadalnix added inline comments.May 22 2020, 14:08

src/rpc/misc.cpp
386 ↗	(On Diff #20503)	Yeah, it's redundant indeed.

Address comments

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10969: Diff 20511.May 22 2020, 14:24

Fabien accepted this revision.May 22 2020, 14:48

This revision is now accepted and ready to land.May 22 2020, 14:48

Closed by commit rABC5a5256baa9ab: rpc: Document default values for optional arguments (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhyMay 22 2020, 14:50

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC5a5256baa9ab: rpc: Document default values for optional arguments.

Revision Contents
Changeset List

Path

Size

src/

rpc/

10 lines

6 lines

9 lines

25 lines

rawtransaction.cpp

25 lines

3 lines

2 lines

wallet/

4 lines

115 lines

Diff 20511

src/rpc/blockchain.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/misc.cpp

Loading...

src/rpc/net.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/rpc/server.cpp

Loading...

src/rpc/util.h

Loading...

src/wallet/rpcdump.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...