Differential D6219

[refactor] change orphan txs std::map member to use TxId instead of uint256
ClosedPublic
Actions

Authored by majcosta on May 22 2020, 15:12.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC1ca8fd1636b0: [refactor] change orphan txs std::map member to use TxId instead of uint256

Summary

for type safety. as long as i'm touching those lines, I also added
auto liberally and const where appropriate

Test Plan

ninja check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

refactor_net_processing

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10981
Build 20196: Default Diff Build & Tests
Build 20195: Build without Wallet
Build 20194: Build with clang-10
Build 20193: arc lint + arc unit

Event Timeline

majcosta created this revision.May 22 2020, 15:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 15:12

majcosta requested review of this revision.May 22 2020, 15:12

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

deadalnix requested changes to this revision.May 22 2020, 15:25

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/net_processing.cpp
1063 ↗	(On Diff #20513)	So it's not a hash, is it?
1131 ↗	(On Diff #20513)	So it is not a random hash, is it?
2891 ↗	(On Diff #20513)	dito

This revision now requires changes to proceed.May 22 2020, 15:25

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10970: Diff 20513.May 22 2020, 15:27

addressed comments, added more explicit names, replaced a constructor initialization with list initialization to guard against narrowind conversions, made a TxId function parameter const