Page MenuHomePhabricator
Differential D6235

[backport#15644] Interrupt orphan processing after every transaction
ClosedPublic
Actions

Authored by majcosta on May 22 2020, 23:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCc0599ad713d4: [backport#15644] Interrupt orphan processing after every transaction
Summary

This makes orphan processing work like handling getdata messages:
After every actual transaction validation attempt, interrupt
processing to deal with messages arriving from other peers.

Depends on D6217

Concludes backport of Core PR15644

Test Plan
ninja check-all

Diff Detail

Event Timeline

majcosta created this revision.May 22 2020, 23:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 23:30
majcosta requested review of this revision.May 22 2020, 23:30
teamcity edited the summary of this revision. (Show Details)May 22 2020, 23:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 22 2020, 23:34
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/net_processing.cpp
2891 ↗(On Diff #20561)

remove conversion here.

This revision now requires changes to proceed.May 22 2020, 23:34
teamcity added a comment.May 22 2020, 23:41

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 23:42

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 23:42

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 23:45

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 23:46

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

majcosta updated this revision to Diff 20566.May 22 2020, 23:54

removed

teamcity added a comment.May 22 2020, 23:55

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10997: Diff 20561.May 22 2020, 23:56
deadalnix accepted this revision.May 22 2020, 23:57
This revision is now accepted and ready to land.May 22 2020, 23:57
teamcity added a comment.May 23 2020, 00:05

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 23 2020, 00:06

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 23 2020, 00:07

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 23 2020, 00:07

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 23 2020, 00:10

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 23 2020, 00:17

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11000: Diff 20566.May 23 2020, 00:17
Closed by commit rABCc0599ad713d4: [backport#15644] Interrupt orphan processing after every transaction (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyMay 23 2020, 00:20
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCc0599ad713d4: [backport#15644] Interrupt orphan processing after every transaction.

Revision Contents
Changeset List

PathSize
src/
2 lines
19 lines

Diff 20566

View Options

src/net.h

Loading...
View Options

src/net_processing.cpp

Loading...