Page MenuHomePhabricator
Differential D6217

[backport#15644] [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx
ClosedPublic
Actions

Authored by majcosta on May 22 2020, 00:00.

Details

Reviewers
nakihito
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5877d0a94553: [backport#15644] [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx
Summary

https://github.com/bitcoin/bitcoin/pull/15644/commits/6e051f3d323af1d209c02e7a4319834f1947ffa7

Depends on D6216

Partial backport of Core PR15644

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 22 2020, 00:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 00:00
majcosta requested review of this revision.May 22 2020, 00:00
teamcity edited the summary of this revision. (Show Details)May 22 2020, 00:00

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 22 2020, 00:01

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 00:01

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 00:01

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 00:03

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 00:05

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 22 2020, 00:10

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10967: Diff 20502.May 22 2020, 00:10
nakihito accepted this revision.May 22 2020, 00:41
This revision is now accepted and ready to land.May 22 2020, 00:41
deadalnix requested changes to this revision.May 22 2020, 13:45
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/net_processing.cpp
2100 ↗(On Diff #20502)

You still clearly have a problem with TxId here.

This revision now requires changes to proceed.May 22 2020, 13:45
majcosta updated this revision to Diff 20557.May 22 2020, 23:03

rebase

teamcity added a comment.May 22 2020, 23:17

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 23:18

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 23:20

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 23:22

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 23:23

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

majcosta added a child revision: D6235: [backport#15644] Interrupt orphan processing after every transaction.May 22 2020, 23:30
deadalnix requested changes to this revision.May 22 2020, 23:33
deadalnix added inline comments.
src/net_processing.cpp
2097 ↗(On Diff #20557)

Remove explicit conversion here.

This revision now requires changes to proceed.May 22 2020, 23:33
teamcity added a comment.May 22 2020, 23:34

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10996: Diff 20557.May 22 2020, 23:34
majcosta updated this revision to Diff 20565.May 22 2020, 23:52

removed

deadalnix accepted this revision.May 22 2020, 23:57
This revision is now accepted and ready to land.May 22 2020, 23:57
teamcity added a comment.May 23 2020, 00:00

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 23 2020, 00:02

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 23 2020, 00:02

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 23 2020, 00:02

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 23 2020, 00:05

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 23 2020, 00:13

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10999: Diff 20565.May 23 2020, 00:13
Closed by commit rABC5877d0a94553: [backport#15644] [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyMay 23 2020, 00:16
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5877d0a94553: [backport#15644] [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx.

Revision Contents
Changeset List

PathSize
src/
158 lines

Diff 20568

View Options

src/net_processing.cpp

Loading...