Page MenuHomePhabricator
Differential D6270

[backport#15435] Merge #15435: rpc: Add missing #include
ClosedPublic
Actions

Authored by majcosta on May 27 2020, 21:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCdc38fa1b733c: [backport#15435] Merge #15435: rpc: Add missing #include
Summary

39e20fc54f Add missing #include. (Daniel Kraft)

Pull request description:

bd0dbe8763fc3029cf96531c9ccaba280b939445 introduced a dependency of `rpc/util.h` on `RPCErrorCode`, defined in `rpc/protocol.h`.  The latter file is only included from `rpc/util.cpp`, though.  This commit fixes the missing include, by moving the `#include` of `rpc/protocol.h` to `rpc/util.h`.

Tree-SHA512: 75c03cfadb28a309d6deb36feeb0ee6ce0b38e8a1176919bc611ea720feff8c42ec9ed0ac8ab74ba9c531a3b7ec9ccbed0c8692ebdf5f9fc17867b9750a1d9f6

Backport of Core PR15435

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta created this revision.May 27 2020, 21:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2020, 21:49
majcosta requested review of this revision.May 27 2020, 21:49
teamcity edited the summary of this revision. (Show Details)May 27 2020, 21:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 27 2020, 21:50

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 27 2020, 21:50

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 27 2020, 21:50

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 27 2020, 21:52

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 27 2020, 21:53

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 27 2020, 21:59

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11055: Diff 20654.May 27 2020, 21:59
Fabien accepted this revision.May 28 2020, 08:10
Fabien added a subscriber: Fabien.

It's fantastic to see a diff entitled Add missing #include which only removes an #include :)

This revision is now accepted and ready to land.May 28 2020, 08:10
Closed by commit rABCdc38fa1b733c: [backport#15435] Merge #15435: rpc: Add missing #include (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyMay 28 2020, 14:00
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCdc38fa1b733c: [backport#15435] Merge #15435: rpc: Add missing #include.

Revision Contents
Changeset List

PathSize
src/
rpc/
1 line

Diff 20654

View Options

src/rpc/util.cpp

Loading...