Page MenuHomePhabricator
Differential D6295

[backport#15139] util: Make ToLower and ToUpper take a char
ClosedPublic
Actions

Authored by majcosta on May 29 2020, 18:04.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC47de8cc58f9c: [backport#15139] util: Make ToLower and ToUpper take a char
Summary

Unfortunately, std::string elements are (bare) chars. As these
are the most likely type to be passed to these functions, make them use
char instead of unsigned char. This avoids some casts.

https://github.com/bitcoin/bitcoin/pull/15139/commits/332b3dd7c156daa08df347dc3359f0ee99ce4baa

Depends on D6294

Concludes backport of Core PR15139

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta created this revision.May 29 2020, 18:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2020, 18:04
majcosta requested review of this revision.May 29 2020, 18:05
teamcity edited the summary of this revision. (Show Details)May 29 2020, 18:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 29 2020, 18:05

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 29 2020, 18:05

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 29 2020, 18:05

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 29 2020, 18:07

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 29 2020, 18:11

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 29 2020, 18:18

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11087: Diff 20708.May 29 2020, 18:18
deadalnix requested changes to this revision.May 29 2020, 21:32
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/util/strencodings.h
224 ↗(On Diff #20708)

Please use char here as the intent is for this to be a character, not a signed 8bit integer.

Also, char signedness is plateform dependent.

This revision now requires changes to proceed.May 29 2020, 21:32
majcosta updated this revision to Diff 20732.May 30 2020, 02:59

converted return type and parameter of ToUpper/ToLower functions to char as in the PR

teamcity added a comment.May 30 2020, 02:59

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 30 2020, 02:59

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 30 2020, 02:59

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 30 2020, 03:02

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 30 2020, 03:04

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 30 2020, 03:11

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11104: Diff 20732.May 30 2020, 03:11
deadalnix accepted this revision.May 31 2020, 21:57
This revision is now accepted and ready to land.May 31 2020, 21:57
majcosta updated this revision to Diff 20787.Jun 2 2020, 14:32

rebase

teamcity added a comment.Jun 2 2020, 14:33

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.Jun 2 2020, 14:33

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.Jun 2 2020, 14:33

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Jun 2 2020, 14:35

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.Jun 2 2020, 14:37

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.Jun 2 2020, 14:45

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B11135: Diff 20787.Jun 2 2020, 14:45
Closed by commit rABC47de8cc58f9c: [backport#15139] util: Make ToLower and ToUpper take a char (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by majcosta). · Explain WhyJun 2 2020, 18:20
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC47de8cc58f9c: [backport#15139] util: Make ToLower and ToUpper take a char.

Revision Contents
Changeset List

PathSize
src/
test/
4 lines
2 lines
util/
4 lines
3 lines

Diff 20787

View Options

src/test/util_tests.cpp

Loading...
View Options

src/uint256.cpp

Loading...
View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...