Page MenuHomePhabricator
Differential D6414

Have importaddress use ImportScripts and ImportScriptPubKeys
ClosedPublic
Actions

Authored by deadalnix on Jun 6 2020, 18:01.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC92fe476dac2d: Have importaddress use ImportScripts and ImportScriptPubKeys
Summary

Also removes the now unused ImportAddress and ImportScript from rpcdump.cpp

Behavior changes:

  • No errors will be thrown when the script or key already exists in the wallet.
  • If the key or script is already in the wallet, their labels will be updated.

This is a partial backport of Core PR16301 : https://github.com/bitcoin/bitcoin/pull/16301/commits/94bf156f391759420465b2ff8c44f5f150246c7f

Depends on D6413

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.Jun 6 2020, 18:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 18:01
deadalnix requested review of this revision.Jun 6 2020, 18:01
teamcity edited the summary of this revision. (Show Details)Jun 6 2020, 18:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11263: Diff 20999.Jun 6 2020, 18:12
deadalnix added a child revision: D6415: Optionally allow ImportScripts to set script creation timestamp.Jun 6 2020, 18:24
majcosta accepted this revision.Jun 7 2020, 21:02
This revision is now accepted and ready to land.Jun 7 2020, 21:02
Closed by commit rABC92fe476dac2d: Have importaddress use ImportScripts and ImportScriptPubKeys (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJun 7 2020, 21:57
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC92fe476dac2d: Have importaddress use ImportScripts and ImportScriptPubKeys.

Revision Contents
Changeset List

PathSize
src/
wallet/
67 lines

Diff 20999

View Options

src/wallet/rpcdump.cpp

Loading...