Page MenuHomePhabricator
Differential D6400

[refactor] Move tx relay state to separate structure
ClosedPublic
Actions

Authored by deadalnix on Jun 5 2020, 23:30.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rABCd80ffc2408df: [refactor] Move tx relay state to separate structure
Summary

This is a partial backport of Core PR15759 : https://github.com/bitcoin/bitcoin/pull/15759/commits/4de0dbac9b286c42a9b10132b7c2d76712f1a319

Depends on D6399 and D6398

Test Plan
ninja all check-all

Diff Detail

Event Timeline

deadalnix created this revision.Jun 5 2020, 23:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2020, 23:30
deadalnix requested review of this revision.Jun 5 2020, 23:30
teamcity edited the summary of this revision. (Show Details)Jun 5 2020, 23:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11246: Diff 20972.Jun 5 2020, 23:41
deadalnix added a child revision: D6401: [refactor] Change tx_relay structure to be unique_ptr.Jun 6 2020, 00:13
nakihito requested changes to this revision.Jun 6 2020, 01:11
nakihito added a subscriber: nakihito.
nakihito added inline comments.
src/net.cpp
2730 ↗(On Diff #20972)

This is not part of the original PR. It is part of PR15654.

src/net.h
734 ↗(On Diff #20972)
743–747 ↗(On Diff #20972)

Re-layout comment.

745 ↗(On Diff #20972)
This revision now requires changes to proceed.Jun 6 2020, 01:11
deadalnix updated this revision to Diff 21008.Jun 6 2020, 22:30

Relayout comments and remove changes from PR15654.

Harbormaster completed remote builds in B11271: Diff 21008.Jun 6 2020, 22:43
nakihito accepted this revision.Jun 6 2020, 22:46
This revision is now accepted and ready to land.Jun 6 2020, 22:46
Closed by commit rABCd80ffc2408df: [refactor] Move tx relay state to separate structure (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by deadalnix). · Explain WhyJun 6 2020, 23:14
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCd80ffc2408df: [refactor] Move tx relay state to separate structure.

Revision Contents
Changeset List

PathSize
src/
77 lines
19 lines
117 lines

Diff 21008

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...