Differential D6400

[refactor] Move tx relay state to separate structure
ClosedPublic
Actions

Authored by deadalnix on Jun 5 2020, 23:30.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd80ffc2408df: [refactor] Move tx relay state to separate structure

Summary

This is a partial backport of Core PR15759 : https://github.com/bitcoin/bitcoin/pull/15759/commits/4de0dbac9b286c42a9b10132b7c2d76712f1a319

Depends on D6399 and D6398

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 5 2020, 23:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2020, 23:30

deadalnix requested review of this revision.Jun 5 2020, 23:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11246: Diff 20972.Jun 5 2020, 23:41

deadalnix added a child revision: D6401: [refactor] Change tx_relay structure to be unique_ptr.Jun 6 2020, 00:13

nakihito requested changes to this revision.Jun 6 2020, 01:11

nakihito added a subscriber: nakihito.

nakihito added inline comments.

src/net.cpp
2730 ↗	(On Diff #20972)	This is not part of the original PR. It is part of PR15654.
src/net.h
734 ↗	(On Diff #20972)
743–747 ↗	(On Diff #20972)	Re-layout comment.
745 ↗	(On Diff #20972)

This revision now requires changes to proceed.Jun 6 2020, 01:11

Relayout comments and remove changes from PR15654.

Harbormaster completed remote builds in B11271: Diff 21008.Jun 6 2020, 22:43

nakihito accepted this revision.Jun 6 2020, 22:46

This revision is now accepted and ready to land.Jun 6 2020, 22:46

Closed by commit rABCd80ffc2408df: [refactor] Move tx relay state to separate structure (authored by Suhas Daftuar <sdaftuar@gmail.com>, committed by deadalnix). · Explain WhyJun 6 2020, 23:14

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCd80ffc2408df: [refactor] Move tx relay state to separate structure.

Revision Contents
Changeset List

Path

Size

src/

77 lines

19 lines

net_processing.cpp

117 lines

Diff 21011

src/net.h

Loading...

src/net.cpp

Loading...

src/net_processing.cpp

Loading...