Explicitely pass the mempool down in some test
ClosedPublic
Actions

Authored by deadalnix on Jun 7 2020, 16:30.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC66c8601ef2bf: Explicitely pass the mempool down in some test

Summary

This remove some references to the global mempool and move closer to it being removed.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

passmempool

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11291
Build 21403: Default Diff Build & Tests
Build 21402: Build without Wallet
Build 21401: Build with clang-10
Build 21400: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 7 2020, 16:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2020, 16:30

deadalnix requested review of this revision.Jun 7 2020, 16:30

Harbormaster completed remote builds in B11291: Diff 21041.Jun 7 2020, 16:44

deadalnix added a child revision: D6439: scripted-diff: Replace ::mempool with m_node.mempool in tests.Jun 7 2020, 16:48

Fabien accepted this revision.Jun 8 2020, 07:27

This revision is now accepted and ready to land.Jun 8 2020, 07:27

Closed by commit rABC66c8601ef2bf: Explicitely pass the mempool down in some test (authored by deadalnix). · Explain WhyJun 8 2020, 12:01

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC66c8601ef2bf: Explicitely pass the mempool down in some test.

deadalnix mentioned this in D6429: Add 2 outbound block-relay-only connections.Jun 8 2020, 13:47

Revision Contents
Changeset List

Path

Size

src/

test/

blockfilter_index_tests.cpp

16 lines

miner_tests.cpp

47 lines

validation_block_tests.cpp

28 lines

Diff 21041

View Options

src/test/blockfilter_index_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/validation_block_tests.cpp

Explicitely pass the mempool down in some testClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21041

src/test/blockfilter_index_tests.cpp

src/test/miner_tests.cpp

src/test/validation_block_tests.cpp

Explicitely pass the mempool down in some test
ClosedPublic
Actions

Revision Contents
Changeset List