Fix the remaining missing explicit occurrences and add a linter to
prevent introducing new ones.
The linter uses cppcheck, which is natively supported by arcanist.
However we need some more output filtering so I redefined another linter
class inpired by their work.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABC0edc1fe896af: [LINTER] Check for missing explicit
arc lint --everything ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- lint_cppcheck
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Event Timeline
Comment Actions
Separating the explicit from the linter would have been preferable, but this is low enough so that we can live with it.
| arcanist/linter/CppCheckLinter.php | ||
|---|---|---|
| 148 ↗ | (On Diff #21326) | The old classic variation on the if return else pattern :) |
Comment Actions
TBH I didn't expect so much changes when I started !
| arcanist/linter/CppCheckLinter.php | ||
|---|---|---|
| 148 ↗ | (On Diff #21326) | Whoups, it's a shameless copy/paste... |
| CONTRIBUTING.md | ||
|---|---|---|
| 134 ↗ | (On Diff #21332) | Note that when you add new dev dependencies that affect linting, they need to be added to the base image setup script as well. |