Differential D6558

[backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}
ClosedPublic
Actions

Authored by majcosta on Jun 12 2020, 19:07.

Details

Reviewers

nakihito

Group Reviewers

Restricted Project

Commits

rABC33483a05b62d: [backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}

Summary

Moves all of the various SigningProviders out of sign.{cpp,h} and
keystore.{cpp,h}. As such, keystore.{cpp,h} is also removed.

Includes and the Makefile are updated to reflect this. Includes were largely
changed using:
git grep -l "keystore.h" | xargs sed -i -e 's;keystore.h;script/signingprovider.h;g'

https://github.com/bitcoin/bitcoin/pull/16227/commits/37a79a4fccbf6cd65a933594e24e59d36e674653

Depends on D6557

Partial backport of Core PR16227

Test Plan

In CMake build dir:

ninja check-all

In autotools build dir:

make check-recursive
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 12 2020, 19:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 12 2020, 19:07

majcosta requested review of this revision.Jun 12 2020, 19:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11455: Diff 21338.Jun 12 2020, 19:31

Test plan doesn't cover autotools and some small nits.

src/script/signingprovider.h
17 ↗	(On Diff #21338)	Relayout comment.
71 ↗	(On Diff #21338)	Ditto.
111–112 ↗	(On Diff #21338)	Ditto.

This revision now requires changes to proceed.Jun 12 2020, 20:29

majcosta edited the test plan for this revision. (Show Details)Jun 12 2020, 21:38

majcosta edited the test plan for this revision. (Show Details)

updated test plan and addressed comments

majcosta added a child revision: D6560: [backport#16227 7/8] Remove CCryptoKeyStore and move all of it's functionality into CWallet.Jun 12 2020, 21:41

Harbormaster completed remote builds in B11461: Diff 21345.Jun 12 2020, 21:49

majcosta edited the test plan for this revision. (Show Details)Jun 12 2020, 21:50

nakihito accepted this revision.Jun 12 2020, 21:51

This revision is now accepted and ready to land.Jun 12 2020, 21:51

Closed by commit rABC33483a05b62d: [backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h} (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJun 13 2020, 20:15

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC33483a05b62d: [backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

2 lines

Makefile.am

4 lines

bench/

2 lines

2 lines

2 lines

3 lines

1 line

rpc/

rawtransaction.cpp

2 lines

rawtransaction_util.cpp

3 lines

util.cpp

2 lines

script/

1 line

55 lines

72 lines

121 lines

	script/

	signingprovider.cpp
	keystore.cpp

80 lines

test/

denialofservice_tests.cpp

3 lines

multisig_tests.cpp

2 lines

script_p2sh_tests.cpp

2 lines

script_standard_tests.cpp

2 lines

script_tests.cpp

2 lines

transaction_tests.cpp

2 lines

txvalidationcache_tests.cpp

2 lines

wallet/

crypter.h

4 lines

ismine.cpp

1 line

wallet.cpp

2 lines

Diff 21360

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/bench/ccoins_caching.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/keystore.h

View Options

src/keystore.cpp

View Options

src/outputtype.h

View Options

src/outputtype.cpp

View Options

src/psbt.h

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/util.cpp

View Options

src/script/descriptor.h

View Options

src/script/sign.h

View Options

src/script/sign.cpp

View Options

src/script/signingprovider.h

View Options

src/script/signingprovider.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/multisig_tests.cpp

View Options

src/test/script_p2sh_tests.cpp

View Options

src/test/script_standard_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/wallet/crypter.h

View Options

src/wallet/ismine.cpp

View Options

[backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21360

src/CMakeLists.txt

src/Makefile.am

src/bench/ccoins_caching.cpp

src/bitcoin-tx.cpp

src/keystore.h

src/keystore.cpp

src/outputtype.h

src/outputtype.cpp

src/psbt.h

src/rpc/rawtransaction.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/util.cpp

src/script/descriptor.h

src/script/sign.h

src/script/sign.cpp

src/script/signingprovider.h

src/script/signingprovider.cpp

src/test/denialofservice_tests.cpp

src/test/multisig_tests.cpp

src/test/script_p2sh_tests.cpp

src/test/script_standard_tests.cpp

src/test/script_tests.cpp

src/test/transaction_tests.cpp

src/test/txvalidationcache_tests.cpp

src/wallet/crypter.h

src/wallet/ismine.cpp

src/wallet/wallet.cpp

[backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}
ClosedPublic
Actions

Revision Contents
Changeset List